[PR #494] add CommonName to generated certificates #472

New issue

Open

opened 2026-02-25 22:33:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:33:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/494
Author: @elexx
Created: 1/16/2023
Status: 🔄 Open

Base: master ← Head: feat/add-cn

📝 Commits (1)

49fec4a add CN to generated certificates

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 cert.go (+1 -0)

📄 Description

Adding a CN to the subject makes generated certificates usable in DSM (Synology).

I created a certificate, uploaded it to my DSM and are able to use it for example as "System default" certificate. Also DSM now shows a "Issued to:" value:

Without this patch, "Issued to:" was empty and the certificate was not selectable for any usages.

Fixes FiloSottile/mkcert#469

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/494 **Author:** [@elexx](https://github.com/elexx) **Created:** 1/16/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feat/add-cn` --- ### 📝 Commits (1) - [`49fec4a`](https://github.com/FiloSottile/mkcert/commit/49fec4a21908ddf9cb3600fed28ea9c6de8bca93) add CN to generated certificates ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cert.go` (+1 -0) </details> ### 📄 Description Adding a CN to the subject makes generated certificates usable in DSM (Synology). I created a certificate, uploaded it to my DSM and are able to use it for example as "System default" certificate. Also DSM now shows a "Issued to:" value: ![image](https://user-images.githubusercontent.com/221837/212713162-9a4a9de5-9a32-4ff3-a246-ee74654b4a5f.png) Without this patch, "Issued to:" was empty and the certificate was not selectable for any usages. Fixes FiloSottile/mkcert#469 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>