mirror of
https://github.com/FiloSottile/mkcert.git
synced 2026-04-25 21:45:59 +03:00
[PR #464] Added an expiry date flag (-expires) allowing to set an expiry date to the generated certificate #467
Labels
No labels
TLS stack issue
Windows
bug
duplicate
duplicate
enhancement
help wanted
help wanted
pull-request
question
question
root store
waiting for info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mkcert#467
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/FiloSottile/mkcert/pull/464
Author: @ccaffy
Created: 9/1/2022
Status: 🔄 Open
Base:
master← Head:add_configurable_expiration_date_certificates📝 Commits (1)
4934a79Added an expiry date flag (-expires) allowing to set an expiry date to the generated certificate📊 Changes
2 files changed (+25 additions, -5 deletions)
View changed files
📝
cert.go(+6 -4)📝
main.go(+19 -1)📄 Description
Hi Filippo,
I had to test that a "homemade" HTTP server automatically reloads the server certificate without the need to restart it.
In order to do that, I used your very nice tool to generate a certificate. As I wanted to test the certificate renewal, I needed to first generate a certificate that is expired, start my HTTP server, try a transfer, see it failing (
curl: (60) Peer's Certificate has expired.), then re-generate a new certificate that will expire later, re-issue the transfer and see it succeeding.I therefore forked your project and modified to allow me to set a specific expiry date for the certificate to generate. I propose that pull request as a contribution if you believe this is a nice functionality you would like to port in the official version of your tool.
I never programmed in Go before, so please forgive me if you spot ugly things :D
Cheers,
Cedric
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.