[PR #215] [MERGED] analysis.go: use x/tools/go/analysis/multichecker to run analysis tools #417

Closed
opened 2026-02-25 22:33:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/215
Author: @FiloSottile
Created: 11/9/2019
Status: Merged
Merged: 11/9/2019
Merged by: @FiloSottile

Base: masterHead: analysis


📝 Commits (1)

  • c27728e analysis.go: use x/tools/go/analysis/multichecker to run analysis tools

📊 Changes

4 files changed (+107 additions, -8 deletions)

View changed files

📝 .travis.yml (+1 -4)
analysis.go (+80 -0)
📝 go.mod (+5 -2)
📝 go.sum (+21 -2)

📄 Description

This pattern has a number of advantages: it tracks the versions of the
tools in go.mod, it doesn't require installing anything in CI, it runs
all analysis passes at once, and it lets us add custom ones easily.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/215 **Author:** [@FiloSottile](https://github.com/FiloSottile) **Created:** 11/9/2019 **Status:** ✅ Merged **Merged:** 11/9/2019 **Merged by:** [@FiloSottile](https://github.com/FiloSottile) **Base:** `master` ← **Head:** `analysis` --- ### 📝 Commits (1) - [`c27728e`](https://github.com/FiloSottile/mkcert/commit/c27728edd9f0d8ebd17e466e5285b53c86cc379a) analysis.go: use x/tools/go/analysis/multichecker to run analysis tools ### 📊 Changes **4 files changed** (+107 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -4) ➕ `analysis.go` (+80 -0) 📝 `go.mod` (+5 -2) 📝 `go.sum` (+21 -2) </details> ### 📄 Description This pattern has a number of advantages: it tracks the versions of the tools in go.mod, it doesn't require installing anything in CI, it runs all analysis passes at once, and it lets us add custom ones easily. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 22:33:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/mkcert#417
No description provided.