[PR #142] [CLOSED] Change u.Username to u.Name for more readibility #403

New issue

Closed

opened 2026-02-25 22:33:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:33:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/142
Author: @doggy8088
Created: 2/25/2019
Status: ❌ Closed

Base: master ← Head: cn_name

📝 Commits (2)

6e2d089 Change u.Username to u.Name for more readibility
f1f6aca Check u.Name for empty

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 cert.go (+5 -1)

📄 Description

Use the u.User might be better than just use u.Username. It because the userAndHostname used in CommonName and OrganizationalUnit field of the certificate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/142 **Author:** [@doggy8088](https://github.com/doggy8088) **Created:** 2/25/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cn_name` --- ### 📝 Commits (2) - [`6e2d089`](https://github.com/FiloSottile/mkcert/commit/6e2d0895adbc3f7ae1a5bbec1e27530a5d6d8604) Change u.Username to u.Name for more readibility - [`f1f6aca`](https://github.com/FiloSottile/mkcert/commit/f1f6acadf9c092a20bdc5849ef6cc2e15cdd315b) Check u.Name for empty ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cert.go` (+5 -1) </details> ### 📄 Description Use the `u.User` might be better than just use `u.Username`. It because the `userAndHostname` used in **CommonName** and **OrganizationalUnit** field of the certificate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>