[PR #152] [MERGED] Allow email SANs for S/MIME certificates #402

New issue

Closed

opened 2026-02-25 22:33:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:33:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/152
Author: @btoews
Created: 4/9/2019
Status: ✅ Merged
Merged: 4/12/2019
Merged by: @FiloSottile

Base: master ← Head: smime

📝 Commits (2)

803db3b allow email SANs for S/MIME certificates
ba92743 check that parsed email matches user's argument

📊 Changes

2 files changed (+16 additions, -3 deletions)

View changed files

📝 cert.go (+10 -1)
📝 main.go (+6 -2)

📄 Description

This PR allows email addresses to be passed in, along with IP addresses and domain names. Email addresses are added as SANs. The appropriate EKUs are added to the cert based on which types of SANs are present. To identify email addresses, I try parsing them with the net/mail package. This is probably overkill and I'm happy to switch to a regex if that's preferrable.

/fixes https://github.com/FiloSottile/mkcert/issues/143
/cc @jcjones

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/152 **Author:** [@btoews](https://github.com/btoews) **Created:** 4/9/2019 **Status:** ✅ Merged **Merged:** 4/12/2019 **Merged by:** [@FiloSottile](https://github.com/FiloSottile) **Base:** `master` ← **Head:** `smime` --- ### 📝 Commits (2) - [`803db3b`](https://github.com/FiloSottile/mkcert/commit/803db3bc06b476095757f27c0a5e52af4c3d6f7a) allow email SANs for S/MIME certificates - [`ba92743`](https://github.com/FiloSottile/mkcert/commit/ba927432d16608ff3162bc4bee5e72b370945c78) check that parsed email matches user's argument ### 📊 Changes **2 files changed** (+16 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cert.go` (+10 -1) 📝 `main.go` (+6 -2) </details> ### 📄 Description This PR allows email addresses to be passed in, along with IP addresses and domain names. Email addresses are added as SANs. The appropriate EKUs are added to the cert based on which types of SANs are present. To identify email addresses, I try parsing them with the `net/mail` package. This is probably overkill and I'm happy to switch to a regex if that's preferrable. /fixes https://github.com/FiloSottile/mkcert/issues/143 /cc @jcjones --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>