[PR #90] [MERGED] java: don't run keytool during check if we there isn't even one found #388

New issue

Closed

opened 2026-02-25 22:33:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:33:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/90
Author: @adamdecaf
Created: 11/10/2018
Status: ✅ Merged
Merged: 11/26/2018
Merged by: @FiloSottile

Base: master ← Head: java-check-keytool

📝 Commits (1)

8a91d81 java: don't run keytool during check if we there isn't even one found

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 truststore_java.go (+4 -0)

📄 Description

If JAVA_HOME isn't set then keytoolPath has an invalid path. This means checkJava() fails and doesn't tell the problem clearly to the user.

Issue: https://github.com/FiloSottile/mkcert/issues/88

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/90 **Author:** [@adamdecaf](https://github.com/adamdecaf) **Created:** 11/10/2018 **Status:** ✅ Merged **Merged:** 11/26/2018 **Merged by:** [@FiloSottile](https://github.com/FiloSottile) **Base:** `master` ← **Head:** `java-check-keytool` --- ### 📝 Commits (1) - [`8a91d81`](https://github.com/FiloSottile/mkcert/commit/8a91d81c0c06c1de54325f844f3534906ac29733) java: don't run keytool during check if we there isn't even one found ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `truststore_java.go` (+4 -0) </details> ### 📄 Description If JAVA_HOME isn't set then keytoolPath has an invalid path. This means checkJava() fails and doesn't tell the problem clearly to the user. Issue: https://github.com/FiloSottile/mkcert/issues/88 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>