[PR #54] [MERGED] java: fix keytool path detection on windows and JRE/JDK #371

New issue

Closed

opened 2026-02-25 22:33:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:33:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/54
Author: @adamdecaf
Created: 8/13/2018
Status: ✅ Merged
Merged: 8/19/2018
Merged by: @FiloSottile

Base: master ← Head: win-java-keytool-path

📝 Commits (4)

36fda44 java: keytool on windows has .exe suffix
f123997 fix windows slash
57f1733 java: check for jre/ prefix in cross-OS fashion
3ce6d15 Use filepath for Windows support

📊 Changes

1 file changed (+18 additions, -4 deletions)

View changed files

📝 truststore_java.go (+18 -4)

📄 Description

Fixes: https://github.com/FiloSottile/mkcert/issues/53

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/54 **Author:** [@adamdecaf](https://github.com/adamdecaf) **Created:** 8/13/2018 **Status:** ✅ Merged **Merged:** 8/19/2018 **Merged by:** [@FiloSottile](https://github.com/FiloSottile) **Base:** `master` ← **Head:** `win-java-keytool-path` --- ### 📝 Commits (4) - [`36fda44`](https://github.com/FiloSottile/mkcert/commit/36fda44a1733168a721009b404c004a8b9507ee1) java: keytool on windows has .exe suffix - [`f123997`](https://github.com/FiloSottile/mkcert/commit/f123997dd88004f4ec44c826f5a23a4f5a70756d) fix windows slash - [`57f1733`](https://github.com/FiloSottile/mkcert/commit/57f17331a350b241f4463d76d293aadf2a6d1207) java: check for jre/ prefix in cross-OS fashion - [`3ce6d15`](https://github.com/FiloSottile/mkcert/commit/3ce6d1583e9587db5eb459a74d8ab5ac8bf59ca9) Use filepath for Windows support ### 📊 Changes **1 file changed** (+18 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `truststore_java.go` (+18 -4) </details> ### 📄 Description Fixes: https://github.com/FiloSottile/mkcert/issues/53 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>