[PR #46] [MERGED] Add Windows Support #369

New issue

Closed

opened 2026-02-25 22:33:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:33:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/46
Author: @cretz
Created: 7/11/2018
Status: ✅ Merged
Merged: 8/13/2018
Merged by: @FiloSottile

Base: master ← Head: windows-support

📝 Commits (2)

a218f37 Add Windows support to mkcert
5dd27e6 Use serial number to identify cert for deletion on Windows

📊 Changes

1 file changed (+130 additions, -0 deletions)

View changed files

➕ truststore_windows.go (+130 -0)

📄 Description

This is to address issue #42. This uses the win32 crypt API which is what Go uses elsewhere when interfacing with the OS cert store. Also, though there is a "certutil.exe" in Windows, it's not the NSS one and therefore while I reference the FF paths, I left hasCertutil as false for this OS in cert.go.

I took care to make the smallest, self-contained changes I could here for minimal Windows support. However as I mention in #45, this code could benefit from a lot of refactoring and "library-ification". I don't like panicking on error, returning bools, hardcoding CA org name, etc.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/46 **Author:** [@cretz](https://github.com/cretz) **Created:** 7/11/2018 **Status:** ✅ Merged **Merged:** 8/13/2018 **Merged by:** [@FiloSottile](https://github.com/FiloSottile) **Base:** `master` ← **Head:** `windows-support` --- ### 📝 Commits (2) - [`a218f37`](https://github.com/FiloSottile/mkcert/commit/a218f376f52ea330850d6a9f64e03e5974a81cd9) Add Windows support to mkcert - [`5dd27e6`](https://github.com/FiloSottile/mkcert/commit/5dd27e62aa96e3661ec4e0cc502d88feadbe745d) Use serial number to identify cert for deletion on Windows ### 📊 Changes **1 file changed** (+130 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `truststore_windows.go` (+130 -0) </details> ### 📄 Description This is to address issue #42. This uses the win32 crypt API which is what Go uses elsewhere when interfacing with the OS cert store. Also, though there is a "certutil.exe" in Windows, it's not the NSS one and therefore while I reference the FF paths, I left `hasCertutil` as false for this OS in `cert.go`. I took care to make the smallest, self-contained changes I could here for minimal Windows support. However as I mention in #45, this code could benefit from a lot of refactoring and "library-ification". I don't like panicking on error, returning bools, hardcoding CA org name, etc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>