mirror of
https://github.com/FiloSottile/mkcert.git
synced 2026-04-25 05:26:03 +03:00
[GH-ISSUE #282] Remove print of CA location? #182
Labels
No labels
TLS stack issue
Windows
bug
duplicate
duplicate
enhancement
help wanted
help wanted
pull-request
question
question
root store
waiting for info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mkcert#182
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maudnals on GitHub (Jul 31, 2020).
Original GitHub issue: https://github.com/FiloSottile/mkcert/issues/282
When creating the local root CA, its location is printed in the terminal:
Using the local CA at "/Users/<username>/Library/Application Support/mkcert"This makes the local root CA easier to find for an attacker.
Once they would get hold of this, the attacker could make a certificate for all websites, that would be trusted by the developer's system.
=> Should this indication be removed?
This would not be a mitigation, but an upgrade.
Not sure about the pitfalls (and risks?) of doing this.
Discussed with @FiloSottile.
@FiloSottile commented on GitHub (Jul 31, 2020):
Yup, I think this is a good idea. To be clear I am not worried about it making it easier for an attacker to find it (if the attacker is the position to read arbitrary files, it's game over, not printing the path is not going to stop them) but we do want to prevent developers who use mkcert from using or sharing the CA without understanding the danger. Developers mostly don't need the CA, so let's hide it from them.
@polarathene commented on GitHub (Aug 19, 2020):
Agreed that there is little security benefit from hiding that output.
Then add output that informs / reminds them of such, removing the CA location doesn't discourage accessing it, a user will seek it out either way if they want to.
Just to clarify, the main risk is the private key being taken to create certs for a CA that is locally trusted, but the attacker can only phish with replica sites, only able to actually impersonate the URLs of a service used if something like DNS resolution is compromised via MITM attack to redirect them to an IP of the attackers impersonating server instead?
I took the
rootCA.pemand copied it over to my Android device to import as user credentials. That's advised here.There's a CLI option to get the CA location, and the README section I linked to also mentions that, which I guess is sufficient.