starred/markdownlint

Fork 0

mirror of https://github.com/DavidAnson/markdownlint.git synced 2026-04-25 01:05:55 +03:00

[GH-ISSUE #99] trimRight & trimLeft are not part of the ES standard #84

New issue

Closed

opened 2026-03-03 01:23:35 +03:00 by kerem · 6 comments

kerem commented

2026-03-03 01:23:35 +03:00

Owner

Originally created by @lukelex on GitHub (Dec 17, 2017).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/99

I've stumbled on a use case where polyfills are not an option. Ideally I'd suggest rewriting all ocurrencies into using inline functions instead of relying on the client to have it available.

I'm willing to implement this if you agree.

For reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/TrimRight
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/TrimLeft

Originally created by @lukelex on GitHub (Dec 17, 2017). Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/99 I've stumbled on a use case where polyfills are not an option. Ideally I'd suggest rewriting all ocurrencies into using inline functions instead of relying on the client to have it available. I'm willing to implement this if you agree. For reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/TrimRight https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/TrimLeft

kerem

2026-03-03 01:23:35 +03:00

closed this issue
added the
enhancement

fixed in next
labels

kerem commented

2026-03-03 01:23:36 +03:00

Author

Owner

@DavidAnson commented on GitHub (Dec 17, 2017):

Interesting timing, I did this a few days ago: github.com/DavidAnson/markdownlint@1184281c87

It will be part of the next release, probably early January. Is that okay for you?

@DavidAnson commented on GitHub (Dec 17, 2017): Interesting timing, I did this a few days ago: https://github.com/DavidAnson/markdownlint/commit/1184281c87faf2c79026c1ff6d4590b6f39af784 It will be part of the next release, probably early January. Is that okay for you?

kerem commented

2026-03-03 01:23:36 +03:00

Author

Owner

@lukelex commented on GitHub (Dec 18, 2017):

I'll be fine for now since I'm using a forked version with a similar approach.

On another note, It'd be nice to know what're the plans for the project so that noobs like myself can collaborate in ways that you'd be willing to accept.

@lukelex commented on GitHub (Dec 18, 2017): I'll be fine for now since I'm using a [forked](https://github.com/lukelex/markdownlint/commit/2889490e5165186bc287261348bf45d7edf054c3) version with a similar approach. On another note, It'd be nice to know what're the plans for the project so that noobs like myself can collaborate in ways that you'd be willing to accept.

kerem commented

2026-03-03 01:23:36 +03:00

Author

Owner

@DavidAnson commented on GitHub (Dec 18, 2017):

I generally try to work through the issue list, prioritizing bugs. The bulk of issues now are new rules, some of which I’m not sure I agree with, at least not defaulted to enabled which is convention.

What kind of planning do you have in mind?

@DavidAnson commented on GitHub (Dec 18, 2017): I generally try to work through the issue list, prioritizing bugs. The bulk of issues now are new rules, some of which I’m not sure I agree with, at least not defaulted to enabled which is convention. What kind of planning do you have in mind?

kerem commented

2026-03-03 01:23:36 +03:00

Author

Owner

@lukelex commented on GitHub (Dec 28, 2017):

Maybe some general thoughts on upcoming features that are yet to be implemented for future versions. Maybe consider grouping them into a milestone for the next version or tag them with up-for-grabs.

@lukelex commented on GitHub (Dec 28, 2017): Maybe some general thoughts on upcoming features that are yet to be implemented for future versions. Maybe consider grouping them into a milestone for the next version or tag them with `up-for-grabs`.

kerem commented

2026-03-03 01:23:36 +03:00

Author

Owner

@DavidAnson commented on GitHub (Dec 28, 2017):

I don’t have any significant plans that aren’t already reflected in the issue list. Right now, the thing that seems most valuable is enabling custom rules to be added at run time. This will allow anyone to develop and refine any of the proposed rules without waiting on me. I had been deferring this work for a variety of reasons, but recently came up with an approach I think I like. If successful, contributors could pick up any of the rules in the issues list and implement them independently.

@DavidAnson commented on GitHub (Dec 28, 2017): I don’t have any significant plans that aren’t already reflected in the issue list. Right now, the thing that seems most valuable is enabling custom rules to be added at run time. This will allow anyone to develop and refine any of the proposed rules without waiting on me. I had been deferring this work for a variety of reasons, but recently came up with an approach I think I like. If successful, contributors could pick up any of the rules in the issues list and implement them independently.

kerem commented

2026-03-03 01:23:36 +03:00

Author

Owner

@DavidAnson commented on GitHub (Jan 24, 2018):

Released in 0.7.0.

@DavidAnson commented on GitHub (Jan 24, 2018): Released in `0.7.0`.

kerem referenced this issue

2026-03-07 20:02:44 +03:00

[GH-ISSUE #84] Consider using TypeScript or similar for newer ES features #1917