mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-26 01:36:03 +03:00
[GH-ISSUE #1277] Link fragments shows warning MD051 when target is preceeded by emoji. #652
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#652
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AxelBrinck on GitHub (Jun 28, 2024).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/1277
Hi there! 👋🏻
Thanks for the work on this great repository.
Link fragments to sections works fine, until the section has an emoji 😿
The following link:
Redirects to the following section:
But at the same time shows warning: MD051.
The warning disappears if the emoji and the "-" symbol prefixing the link is removed.
I read that prefixing headers with an "-" in link fragments should allow to have an emoji.
Can this be reviewed?
Thanks!
@DavidAnson commented on GitHub (Jun 28, 2024):
Per the documentation, MD051 uses the GitHub heading algorithm as the canonical form for headings:
https://github.com/DavidAnson/markdownlint/blob/main/doc/md051.md
As you can confirm via GitHub, the GitHub representation for the link you show is this:
#arrow_left-username-createdUsing that in Markdown produces no violations from MD051, so I claim the rule is behaving correctly:
https://dlaa.me/markdownlint/#%25m%23%20Issue%201277%0A%0A%23%23%20%3Aarrow_left%3A%20Username%20Created%0A%0A-%20%5BUsername%20Created%5D(%23arrow_left-username-created).%0A
@AxelBrinck commented on GitHub (Jun 28, 2024):
Ah, yes, this works! Thanks a lot for helping! 😸