mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 09:16:02 +03:00
[GH-ISSUE #77] MD041: incorrect frontmatter title checking with TOML frontmatter #62
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#62
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ringods on GitHub (Oct 14, 2017).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/77
Support for #63 was done in commit
github.com/DavidAnson/markdownlint@5bea80f5cd. But in my VSCode 1.17.1 with markdownlint extension 0.10.1, I still getMD041complaints on my Markdown files with TOML frontmatter.Each of my MD files contain a
titleattribute in the frontmatter, followed by plain text e.g.:Hugo renders the
titleas the top levelh1element with the theme I use.Looking at the
markdownlintsources, I suspect the check for the frontmatter title attribute only checks for the YAML version:github.com/DavidAnson/markdownlint@edd426bbaa/lib/rules.js (L1048)The regexp ends with the colon at the end, but in TOML key and value are separated with the equal sign and spaces in between. Can you confirm this?
@DavidAnson commented on GitHub (Oct 14, 2017):
Seems legit, sorry about that. The other commit of interest is
github.com/DavidAnson/markdownlint@942f0600d2which was before the TOML one you cite. This should be straightforward to fix. I’m working on avscode-markdownlintupdate now and may roll this fix in. Thanks!