mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 17:26:22 +03:00
[GH-ISSUE #643] Unicode characters with MD051 #488
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#488
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TomStrepsil on GitHub (Nov 18, 2022).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/643
Given the following markdown:
...the linter complains:
The same is true when trying to percent-encode that:
Should unicode be allowed in in-line links? If so, how should they be specified in grace of the linter?
The commonmark spec has this to say about non-ascii characters in URLs:
...and:
...and regarding in-line links:
@DavidAnson commented on GitHub (Nov 18, 2022):
The documentation for the next release has been updated to clarify this rule enforces the GitHub algorithm for automatic heading link generation. I'm guessing neither of the forms you show successfully connect to a generated link in a document on GitHub - in which case the warning is accurate. If one of those forms does work on GitHub, please give an example and I will look into how that character is being transformed. Thank you!
https://github.com/DavidAnson/markdownlint/blob/next/doc/md051.md
@TomStrepsil commented on GitHub (Nov 18, 2022):
Thanks for the feedback! I realised subsequently that GitHub actually wants a link to this:
...to appear thus:
...so I think a leading hyphen, but omitting the unicode character, seems to work in this instance.
@DavidAnson commented on GitHub (Nov 18, 2022):
Great. What you show above produces no warnings so I will close this issue.
https://dlaa.me/markdownlint/#%25m%23%20Issue%20643%0A%0A%23%23%20%F0%9F%94%97%20Link%0A%0A%5BLink%5D(%23-link)%0A