mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 09:16:02 +03:00
[GH-ISSUE #591] MD051/link-fragments false positive when code syntax is used #466
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#466
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @undergroundwires on GitHub (Oct 1, 2022).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/591
First of all thank you for the great tool. I use it on almost all of my projects. After upgrading to new version, I realized that MD051 fails to detect valid headers when code ``` backticks are used.
Example:
This is valid link and valid markdown but I get
MD051/link-fragments Link fragments should be validerror.Here is the markdown I use it on.
@nschonni commented on GitHub (Oct 1, 2022):
It complains about the anchor not being lowercase, not the backticks
@undergroundwires commented on GitHub (Oct 1, 2022):
Thank you for super fast response @nschonni , I'm too stupid, sorry for taking your time.
@nschonni commented on GitHub (Oct 1, 2022):
No worries, it's one I hit before too. Not sure if the messaging needs to be updated
@DavidAnson commented on GitHub (Oct 1, 2022):
I made myself a note to look into that.
@MFTabriz commented on GitHub (Oct 11, 2022):
Does the anchor really need to be in lowercase? RfC 3986 does not define the URI fragment as case in-sensitive (so it does not require normalization).
PS: I guess it must be due to the way it's been implemented in GH!
@DavidAnson commented on GitHub (Oct 11, 2022):
That's correct, GitHub appears to always use lowercase, and so that is the form this rule requires.