mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-26 01:36:03 +03:00
[GH-ISSUE #536] MD051 doesn't recognize capital accent characters #438
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#438
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nschonni on GitHub (Jul 20, 2022).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/536
I had the following, and originally thought it was the accented characters, but it looks like it's actually the fact that Markdownlint keeps the
', but GitHub strips it in the auto-anchorLive version https://github.com/canada-ca/ore-ero/blob/master/_data/README.md
@DavidAnson commented on GitHub (Jul 21, 2022):
Remember that GitHub lower-cases every character when making the link for a heading. Your sample still has a capital letter (
É) - lower-casing it passes the rule as currently implemented: https://dlaa.me/markdownlint/#%25m%23%20Issue%20536%0A%0A%23%23%20Donn%C3%A9es%20pour%20l'%C3%89change%20de%20ressources%20ouvert%0A%0A%5BFran%C3%A7ais%5D(%23donn%C3%A9es-pour-l%C3%A9change-de-ressources-ouvert)%0AThere are probably a few different ways this could work, but the all-lower-case the rule enforces now reflects what shows up in the browser URL (in Chrome) and seems like a reasonable canonical implementation.
@nschonni commented on GitHub (Jul 21, 2022):
Yeah, looks like I was missreading the double encoding characters as the apostrophe then the accent character, but it was just the accented character. I know this rule gets a little fuzzy since it isn't a CommonMark spec'd thing.
PS: also ran into an issue with the MDN content repo because their anchor generator behaves differently, but I haven't come up with an option proposal yet