starred/markdownlint

Fork 0

mirror of https://github.com/DavidAnson/markdownlint.git synced 2026-04-25 01:05:55 +03:00

[GH-ISSUE #50] MD044 - Links and code should be excluded from checks #41

New issue

Closed

opened 2026-03-03 01:23:15 +03:00 by kerem · 5 comments

kerem commented

2026-03-03 01:23:15 +03:00

Owner

Originally created by @flodolo on GitHub (Mar 17, 2017).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/50

First of all, thanks for this great tool. I've been experimenting with it for the last couple of days and it works great.

I'm really interested in this rule, but it fails short with its current implementation. Example:

  "proper-names": {
      "names": [
          "GitHub"
      ]
  }

All docs fail where there's a link to GitHub. I think there should be an option to exclude links, URLs, and code from this check, and it should probably be true by default.

Originally created by @flodolo on GitHub (Mar 17, 2017). Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/50 First of all, thanks for this great tool. I've been experimenting with it for the last couple of days and it works great. I'm really interested in this rule, but it fails short with its current implementation. Example: ``` "proper-names": { "names": [ "GitHub" ] } ``` All docs fail where there's a link to GitHub. I think there should be an option to exclude links, URLs, and code from this check, and it should probably be true by default.

kerem

2026-03-03 01:23:15 +03:00

closed this issue
added the
enhancement

fixed in next
labels

kerem commented

2026-03-03 01:23:16 +03:00

Author

Owner

@DavidAnson commented on GitHub (Mar 17, 2017):

Please have a look at the tests for the following commit I made about an hour ago: github.com/DavidAnson/markdownlint@935935b96c

I think you will find it addresses exactly the issues you raise. :)

@DavidAnson commented on GitHub (Mar 17, 2017): Please have a look at the tests for the following commit I made about an hour ago: https://github.com/DavidAnson/markdownlint/commit/935935b96c4196df795fa8d2feb4870bbb13306d I think you will find it addresses exactly the issues you raise. :)

kerem commented

2026-03-03 01:23:16 +03:00

Author

Owner

@DavidAnson commented on GitHub (Mar 17, 2017):

Actually, it explicitly INcludes code - what is your scenario where that is not wanted?

@DavidAnson commented on GitHub (Mar 17, 2017): Actually, it explicitly INcludes code - what is your scenario where that is not wanted?

kerem commented

2026-03-03 01:23:16 +03:00

Author

Owner

@flodolo commented on GitHub (Mar 17, 2017):

Please have a look at the tests for the following commit I made about an hour ago: 935935b

Ah, that's great.

Actually, it explicitly INcludes code - what is your scenario where that is not wanted?

For example an HTML code fragment that includes links. It would also be great to ignore bare URLs, not just properly formatted links.

@flodolo commented on GitHub (Mar 17, 2017): > Please have a look at the tests for the following commit I made about an hour ago: 935935b Ah, that's great. > Actually, it explicitly INcludes code - what is your scenario where that is not wanted? For example an HTML code fragment that includes links. It would also be great to ignore bare URLs, not just properly formatted links.

kerem commented

2026-03-03 01:23:16 +03:00

Author

Owner

@DavidAnson commented on GitHub (Mar 17, 2017):

I'll probably allow excluding code, thanks.

I debated whether to special case bare URLs already - why not use a proper link instead?

@DavidAnson commented on GitHub (Mar 17, 2017): I'll probably allow excluding code, thanks. I debated whether to special case bare URLs already - why not use a proper link instead?

kerem commented

2026-03-03 01:23:16 +03:00

Author

Owner

@flodolo commented on GitHub (Mar 17, 2017):

I debated whether to special case bare URLs already - why not use a proper link instead?

I guess mostly for lazyness. If you want to write https://atom.io/, it's easier to use the bare URL than writing [https://atom.io/](https://atom.io, especially if you want to display the URL.

@flodolo commented on GitHub (Mar 17, 2017): > I debated whether to special case bare URLs already - why not use a proper link instead? I guess mostly for lazyness. If you want to write https://atom.io/, it's easier to use the bare URL than writing `[https://atom.io/](https://atom.io`, especially if you want to display the URL.

kerem referenced this issue

2026-03-07 20:02:22 +03:00

[GH-ISSUE #41] Add rule to check for file naming #1880