starred/markdownlint

Fork 0

mirror of https://github.com/DavidAnson/markdownlint.git synced 2026-04-26 01:36:03 +03:00

[GH-ISSUE #485] MD031 fix in lists adding extra list item markers #399

New issue

Closed

opened 2026-03-03 01:26:34 +03:00 by kerem · 4 comments

kerem commented

2026-03-03 01:26:34 +03:00

Owner

Originally created by @nschonni on GitHub (Jan 18, 2022).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/485

Source

1.  ```js
    alert('hello!');
    ```
2.  ```js
    document.querySelector('html').style.backgroundColor = 'purple';
    ```
3.  ```js
    const myWordmark = document.createElement('img');
    myWordmark.setAttribute('src','https://blog.mozilla.org/press/wp-content/themes/OneMozilla/img/mozilla-wordmark.png');
    document.querySelector('h1').appendChild(myWordmark);
    ```

Result

1.  ```js
    alert('hello!');
    ```
2.
2.  ```js
    document.querySelector('html').style.backgroundColor = 'purple';
    ```
3.
3.  ```js
    const myWordmark = document.createElement('img');
    myWordmark.setAttribute('src','https://blog.mozilla.org/press/wp-content/themes/OneMozilla/img/mozilla-wordmark.png');
    document.querySelector('h1').appendChild(myWordmark);
    ```

Originally created by @nschonni on GitHub (Jan 18, 2022). Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/485 Source ~~~md 1. ```js alert('hello!'); ``` 2. ```js document.querySelector('html').style.backgroundColor = 'purple'; ``` 3. ```js const myWordmark = document.createElement('img'); myWordmark.setAttribute('src','https://blog.mozilla.org/press/wp-content/themes/OneMozilla/img/mozilla-wordmark.png'); document.querySelector('h1').appendChild(myWordmark); ``` ~~~ Result ~~~md 1. ```js alert('hello!'); ``` 2. 2. ```js document.querySelector('html').style.backgroundColor = 'purple'; ``` 3. 3. ```js const myWordmark = document.createElement('img'); myWordmark.setAttribute('src','https://blog.mozilla.org/press/wp-content/themes/OneMozilla/img/mozilla-wordmark.png'); document.querySelector('h1').appendChild(myWordmark); ``` ~~~

kerem

2026-03-03 01:26:34 +03:00

closed this issue
added the
bug

fixed in next
labels

kerem commented

2026-03-03 01:26:35 +03:00

Author

Owner

@nschonni commented on GitHub (Jan 18, 2022):

Also noticed this for unordered lists

Source:

There are two ways to specify a page action: with or without a [popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups).

- **Without a popup:** When the user clicks the button, an event is dispatched to the extension, which the extension listens for using [`pageAction.onClicked`](/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction/onClicked "Fired when a browser action icon is clicked. This event will not fire if the browser action has a popup."):
- ```js
  browser.pageAction.onClicked.addListener(handleClick);
  ```
- **With a popup:** the `click` event is not dispatched. Instead, the popup appears when the user clicks the button. The user then interacts with the popup. When the user clicks outside of the popup, it closes automatically. See the [Popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups) article for more details on creating and managing popups.

Result

There are two ways to specify a page action: with or without a [popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups).

- **Without a popup:** When the user clicks the button, an event is dispatched to the extension, which the extension listens for using [`pageAction.onClicked`](/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction/onClicked "Fired when a browser action icon is clicked. This event will not fire if the browser action has a popup."):
-
- ```js
  browser.pageAction.onClicked.addListener(handleClick);
  ```

- **With a popup:** the `click` event is not dispatched. Instead, the popup appears when the user clicks the button. The user then interacts with the popup. When the user clicks outside of the popup, it closes automatically. See the [Popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups) article for more details on creating and managing popups.

@nschonni commented on GitHub (Jan 18, 2022): Also noticed this for unordered lists Source: ~~~md There are two ways to specify a page action: with or without a [popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups). - **Without a popup:** When the user clicks the button, an event is dispatched to the extension, which the extension listens for using [`pageAction.onClicked`](/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction/onClicked "Fired when a browser action icon is clicked. This event will not fire if the browser action has a popup."): - ```js browser.pageAction.onClicked.addListener(handleClick); ``` - **With a popup:** the `click` event is not dispatched. Instead, the popup appears when the user clicks the button. The user then interacts with the popup. When the user clicks outside of the popup, it closes automatically. See the [Popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups) article for more details on creating and managing popups. ~~~ Result ~~~md There are two ways to specify a page action: with or without a [popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups). - **Without a popup:** When the user clicks the button, an event is dispatched to the extension, which the extension listens for using [`pageAction.onClicked`](/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction/onClicked "Fired when a browser action icon is clicked. This event will not fire if the browser action has a popup."): - - ```js browser.pageAction.onClicked.addListener(handleClick); ``` - **With a popup:** the `click` event is not dispatched. Instead, the popup appears when the user clicks the button. The user then interacts with the popup. When the user clicks outside of the popup, it closes automatically. See the [Popup](/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups) article for more details on creating and managing popups. ~~~

kerem commented

2026-03-03 01:26:35 +03:00

Author

Owner

@DavidAnson commented on GitHub (Jan 18, 2022):

I do not see the first behavior in the demo site. Please try there? https://dlaa.me/markdownlint/

I do see the second one.

@DavidAnson commented on GitHub (Jan 18, 2022): I do not see the first behavior in the demo site. Please try there? https://dlaa.me/markdownlint/ I do see the second one.

kerem commented

2026-03-03 01:26:35 +03:00

Author

Owner

@nschonni commented on GitHub (Jan 18, 2022):

Yeah, maybe the OL version is fixed in the core. I'm getting these from markdownlint-cli, but I see the same correct fix in the browser

@nschonni commented on GitHub (Jan 18, 2022): Yeah, maybe the OL version is fixed in the core. I'm getting these from markdownlint-cli, but I see the same correct fix in the browser

kerem commented

2026-03-03 01:26:35 +03:00

Author

Owner

@DavidAnson commented on GitHub (May 15, 2022):

This fixes both scenarios you report above.

@DavidAnson commented on GitHub (May 15, 2022): This fixes both scenarios you report above.

kerem referenced this issue

2026-03-03 01:27:43 +03:00

[GH-ISSUE #753] [New rule] Link can be simplified to autolink #527

kerem referenced this issue

2026-03-03 01:27:43 +03:00