starred/markdownlint

Fork 0

mirror of https://github.com/DavidAnson/markdownlint.git synced 2026-04-25 17:26:22 +03:00

[GH-ISSUE #330] Add fixInfo for MD022 #285

New issue

Closed

opened 2026-03-03 01:25:24 +03:00 by kerem · 9 comments

kerem commented

2026-03-03 01:25:24 +03:00

Owner

Originally created by @nschonni on GitHub (Sep 19, 2020).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/330

It seems like this one should be "fixable". Not sure if you already looked at it and ruled it out because of some edge cases

Originally created by @nschonni on GitHub (Sep 19, 2020). Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/330 It seems like this one should be "fixable". Not sure if you already looked at it and ruled it out because of some edge cases

kerem

2026-03-03 01:25:24 +03:00

closed this issue
added the
question
label

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@DavidAnson commented on GitHub (Sep 19, 2020):

MD022 should include fix info for all scenarios it flags as an error: https://github.com/DavidAnson/markdownlint/blob/main/lib/md022.js

Is that not working or did you mean a different rule?

@DavidAnson commented on GitHub (Sep 19, 2020): MD022 should include fix info for all scenarios it flags as an error: https://github.com/DavidAnson/markdownlint/blob/main/lib/md022.js Is that not working or did you mean a different rule?

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@nschonni commented on GitHub (Sep 20, 2020):

Sorry, I think i'm actually hitting a small bug between cli and cli2.
I was running it against dotnet/docs to try out the fix for that one. cli returns 5K+ changed files, and CLI2 returned ~4K files.
I was getting mixed up because CLI2 was returning errors into the console in addition to some fixed files

@nschonni commented on GitHub (Sep 20, 2020): Sorry, I think i'm actually hitting a small bug between cli and cli2. I was running it against dotnet/docs to try out the fix for that one. cli returns 5K+ changed files, and CLI2 returned ~4K files. I was getting mixed up because CLI2 was returning errors into the console in addition to some fixed files

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@DavidAnson commented on GitHub (Sep 20, 2020):

Can you describe the difference or give an example or the commands to reproduce this?

@DavidAnson commented on GitHub (Sep 20, 2020): Can you describe the difference or give an example or the commands to reproduce this?

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@nschonni commented on GitHub (Sep 20, 2020):

Sure, here is the steps:

Clone dotnet/docs
Remove MD022 suppression in .markdownlint.json
Run markdownlint "**/*.md" --fix
5K+ files updated, no warnings in console
Reset changes, and reapply .markdownlint.json MD022 supression
Run markdownlint-cli2 "**/*.md" --fix
4K< files changed, and console warnings for MD022 issues printed

@nschonni commented on GitHub (Sep 20, 2020): Sure, here is the steps: 1. Clone dotnet/docs 2. Remove MD022 suppression in `.markdownlint.json` 3. Run `markdownlint "**/*.md" --fix` 4. 5K+ files updated, no warnings in console 5. Reset changes, and reapply `.markdownlint.json` MD022 supression 6. Run `markdownlint-cli2 "**/*.md" --fix` 7. 4K< files changed, and console warnings for MD022 issues printed

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@DavidAnson commented on GitHub (Sep 20, 2020):

At the risk of nitpicking, "--fix" is not a command line argument for CLI2; I assume you are setting fix:true in its options file? I can try this and have a look.

@DavidAnson commented on GitHub (Sep 20, 2020): At the risk of nitpicking, "--fix" is not a command line argument for CLI2; I assume you are setting `fix:true` in its options file? I can try this and have a look.

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@nschonni commented on GitHub (Sep 20, 2020):

Nope, was just using the old config format. Not sure why CLI2 was updating the files then :P

@nschonni commented on GitHub (Sep 20, 2020): Nope, was just using the old config format. Not sure why CLI2 was updating the files then :P

kerem commented

2026-03-03 01:25:25 +03:00

Author

Owner

@DavidAnson commented on GitHub (Sep 20, 2020):

I've never seen files get updated without fix:true. If that's happening, please let me know how. The --fix argument should only seem like another file glob.

@DavidAnson commented on GitHub (Sep 20, 2020): I've never seen files get updated without `fix:true`. If that's happening, please let me know how. The `--fix` argument should only seem like another file glob.

kerem commented

2026-03-03 01:25:26 +03:00

Author

Owner

@nschonni commented on GitHub (Sep 20, 2020):

I'll take a look tomorrow again when I'm on my other machine. Feel free to flip this issue over to the cli2 repo though, since it's not really related to the core lib anymore

@nschonni commented on GitHub (Sep 20, 2020): I'll take a look tomorrow again when I'm on my other machine. Feel free to flip this issue over to the cli2 repo though, since it's not really related to the core lib anymore

kerem commented

2026-03-03 01:25:26 +03:00

Author

Owner

@nschonni commented on GitHub (Sep 20, 2020):

You're right, I must have not reset the changes fully. I'll stick with the original CLI for the fixes since the config way is a little annoying when trying out fixes

@nschonni commented on GitHub (Sep 20, 2020): You're right, I must have not reset the changes fully. I'll stick with the original CLI for the fixes since the config way is a little annoying when trying out fixes

kerem referenced this issue

2026-03-07 20:04:29 +03:00

[GH-ISSUE #285] White spaces in link destination #2093