[PR #719] [CLOSED] Added One Sentence per line rule (#66) #2826

New issue

Closed

opened 2026-03-07 20:10:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 20:10:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/DavidAnson/markdownlint/pull/719
Author: @aepfli
Created: 2/14/2023
Status: ❌ Closed

Base: next ← Head: one_sentence_per_line

📝 Commits (5)

8634b5e Added One Sentence per line rule (#66)
30f322a improving detection and adding testcases
f0d7038 improving detection and adding testcases
de10ce8 Adding more test cases
8842e1b different approach with usage of tokens

📊 Changes

19 files changed (+2383 additions, -6 deletions)

View changed files

📝 README.md (+2 -0)
📝 demo/markdownlint-browser.js (+102 -2)
➕ demo/markdownlint-rule-helpers-browser.js (+1274 -0)
➕ demo/markdownlint-rule-helpers-browser.min.js (+2 -0)
➕ doc-build/md054.md (+26 -0)
📝 doc/Rules.md (+47 -0)
➕ doc/md054.md (+44 -0)
📝 lib/constants.js (+2 -1)
➕ lib/md054.js (+81 -0)
📝 lib/rules.js (+2 -1)
📝 schema/.markdownlint.jsonc (+24 -0)
📝 schema/.markdownlint.yaml (+20 -0)
📝 schema/build-config-schema.js (+30 -0)
📝 schema/markdownlint-config-schema.json (+56 -0)
📝 test/markdownlint-test.js (+2 -2)
➕ test/sentences-per-line.json (+19 -0)
➕ test/sentences-per-line.md (+87 -0)
📝 test/snapshots/markdownlint-test-scenarios.js.md (+563 -0)
📝 test/snapshots/markdownlint-test-scenarios.js.snap (+0 -0)

📄 Description

New configurable and fixable rule to fix ensure only one sentence per line. It is configurable, what defines the ending of a sentence as well as ignored words.

Additionally to the new rule, i adapted the logic to create the yaml file, as it did not work properly with arrays.

Signed-off-by: Simon Schrottner simon.schrottner@dynatrace.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/DavidAnson/markdownlint/pull/719 **Author:** [@aepfli](https://github.com/aepfli) **Created:** 2/14/2023 **Status:** ❌ Closed **Base:** `next` ← **Head:** `one_sentence_per_line` --- ### 📝 Commits (5) - [`8634b5e`](https://github.com/DavidAnson/markdownlint/commit/8634b5ef2d70d032ce6615f96a5a42fc0e98af3d) Added One Sentence per line rule (#66) - [`30f322a`](https://github.com/DavidAnson/markdownlint/commit/30f322a57b069dadf6f26df16b082c69ea2d581f) improving detection and adding testcases - [`f0d7038`](https://github.com/DavidAnson/markdownlint/commit/f0d70385dab0a590a61d7d4a6153c8174de11291) improving detection and adding testcases - [`de10ce8`](https://github.com/DavidAnson/markdownlint/commit/de10ce86cdc84b73c7ab43249e04eacbe65f550e) Adding more test cases - [`8842e1b`](https://github.com/DavidAnson/markdownlint/commit/8842e1b436af4d6dbecc3ad1e8ed0f956d914bf7) different approach with usage of tokens ### 📊 Changes **19 files changed** (+2383 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -0) 📝 `demo/markdownlint-browser.js` (+102 -2) ➕ `demo/markdownlint-rule-helpers-browser.js` (+1274 -0) ➕ `demo/markdownlint-rule-helpers-browser.min.js` (+2 -0) ➕ `doc-build/md054.md` (+26 -0) 📝 `doc/Rules.md` (+47 -0) ➕ `doc/md054.md` (+44 -0) 📝 `lib/constants.js` (+2 -1) ➕ `lib/md054.js` (+81 -0) 📝 `lib/rules.js` (+2 -1) 📝 `schema/.markdownlint.jsonc` (+24 -0) 📝 `schema/.markdownlint.yaml` (+20 -0) 📝 `schema/build-config-schema.js` (+30 -0) 📝 `schema/markdownlint-config-schema.json` (+56 -0) 📝 `test/markdownlint-test.js` (+2 -2) ➕ `test/sentences-per-line.json` (+19 -0) ➕ `test/sentences-per-line.md` (+87 -0) 📝 `test/snapshots/markdownlint-test-scenarios.js.md` (+563 -0) 📝 `test/snapshots/markdownlint-test-scenarios.js.snap` (+0 -0) </details> ### 📄 Description New configurable and fixable rule to fix ensure only one sentence per line. It is configurable, what defines the ending of a sentence as well as ignored words. Additionally to the new rule, i adapted the logic to create the yaml file, as it did not work properly with arrays. Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>