mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 09:16:02 +03:00
[GH-ISSUE #280] MD037 does not ignore '_' in link reference #240
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @acascone on GitHub (Apr 30, 2020).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/280
In vscode, I see a warning for
_Setup_ and _Installation_complaining about "Spaces inside emphasis markers" for_ and _but no error for*Setup* and *Installation*.I assume that the behavior with the asterisk is correct, and the underscore is incorrect. I hope the underscore is not the correct interpretation of the rule.
@DavidAnson commented on GitHub (May 1, 2020):
Could you please check you are on the latest version? There was a recent fix in this area in extension release 0.35.1.
Your example looks fine to me in the current implementation: https://dlaa.me/markdownlint/#%25m%23%20Issue%20114%0A%0A_Setup_%20and%20_Installation_%0A%0ASetup%20and%20Installation%0A
@acascone commented on GitHub (May 1, 2020):
Thanks for getting back to me. Here are some additional details.
VS Code Version
Extension Version
I still see the issue.
I am using the following format file.
Please let me know what else I can try.
@DavidAnson commented on GitHub (May 2, 2020):
Please include example Markdown that demonstrates the issue. Per my link above, the simplified version does not seem to.
@acascone commented on GitHub (May 2, 2020):
Ok, I feel like I might have wasted your time. It's related to a reference style link on the line before.
Please see: https://dlaa.me/markdownlint/#%25m%23%20Issue%20114%0A%0A%5Breference_link%5D%0A_Setup_%20and%20_Installation_%20%3C--%20issue%0A%0A%5Breference_link%5D%0ASetup%20and%20Installation%20%3C--%20no%20issue%0A%0A%5Breference_link%5D%3A%20http%3A%2F%2Fwww.example.com%0A
EDIT: updated to show issue with underscore vs not, but still this seems like user error. It was just unexpected.
@DavidAnson commented on GitHub (May 2, 2020):
You are correct that this is a bug in markdownlint. ‘_’ is allowed in a link label, so ideally the linter would recognize that and not try to treat it as the start of an emphasis. Thank you for the example – I will look to improve this in a future release.