starred/markdownlint

Fork 0

mirror of https://github.com/DavidAnson/markdownlint.git synced 2026-04-26 01:36:03 +03:00

[GH-ISSUE #468] Counter-intuitive behavior after enable/disable + bug with ignore next line. #2233

New issue

Closed

opened 2026-03-07 20:05:50 +03:00 by kerem · 6 comments

kerem commented

2026-03-07 20:05:50 +03:00

Owner

Originally created by @adithyabsk on GitHub (Dec 19, 2021).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/468

So I just ran into two separate issues. I was trying to disable an error for a really long iframe embed that I am including in my markdown but was running into all sorts of trouble. I think I was dealing with two separate bugs which is what made it all the more confusing

It seems that if you do the following, it re-enables all the previous ignored rules including deprecated rules such as MD002.

<!-- markdownlint-disable -->
<iframe>Some really long iframe snippet</iframe>
<!-- markdownlint-enable -->

If you instead try to use disable next line in the presence of front-matter, the line does not actually get disabled since it is not offset in the code by the length of the front matter. (I put together a pull request for this issue https://github.com/DavidAnson/markdownlint/pull/469)

<!-- markdownlint-disable-next-line -->
<iframe>Some really long iframe snippet</iframe>

Originally created by @adithyabsk on GitHub (Dec 19, 2021). Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/468 So I just ran into two separate issues. I was trying to disable an error for a really long iframe embed that I am including in my markdown but was running into all sorts of trouble. I think I was dealing with two separate bugs which is what made it all the more confusing It seems that if you do the following, it re-enables all the previous ignored rules including deprecated rules such as MD002. ```md  <iframe>Some really long iframe snippet</iframe>  ``` If you instead try to use disable next line in the presence of front-matter, the line does not actually get disabled since it is not offset in the code by the length of the front matter. (I put together a pull request for this issue https://github.com/DavidAnson/markdownlint/pull/469) ```md  <iframe>Some really long iframe snippet</iframe> ```

kerem

2026-03-07 20:05:50 +03:00

closed this issue
added the
question
label

kerem commented

2026-03-07 20:05:51 +03:00

Author

Owner

@nschonni commented on GitHub (Dec 19, 2021):

https://github.com/DavidAnson/markdownlint#configuration explains that you need to capture first if you want to restore the same ruleset

@nschonni commented on GitHub (Dec 19, 2021): https://github.com/DavidAnson/markdownlint#configuration explains that you need to `capture` first if you want to restore the same ruleset

kerem commented

2026-03-07 20:05:51 +03:00

Author

Owner

@adithyabsk commented on GitHub (Dec 19, 2021):

explains that you need to capture first if you want to restore the same ruleset

Ah, you know what. Now that I've spent some time running through the code base re-reading that section makes a lot more sense. Don't think the wording could be made any clearer--I just missed the capture example.

And, yep. The capture/restore pattern seems to work. I promise I did run through the issues before creating this one, and I hope this issue helps someone else who missed that part of the docs.

<!-- markdownlint-capture -->
<!-- markdownlint-disable -->
<iframe>long snippet</iframe>
<!-- markdownlint-restore -->

Thought, it still would be nice to be able to use the one-liner which I was able to reproduce as an error.

@adithyabsk commented on GitHub (Dec 19, 2021): > explains that you need to capture first if you want to restore the same ruleset Ah, you know what. Now that I've spent some time running through the code base re-reading that section makes a lot more sense. Don't think the wording could be made any clearer--I just missed the capture example. And, yep. The capture/restore pattern seems to work. I promise I did run through the issues before creating this one, and I hope this issue helps someone else who missed that part of the docs. ```md   <iframe>long snippet</iframe>  ``` Thought, it still would be nice to be able to use the one-liner which I was able to reproduce as an error.

kerem commented

2026-03-07 20:05:51 +03:00

Author

Owner

@DavidAnson commented on GitHub (Dec 19, 2021):

Glad you got this sorted out! If there's an example of something not working, please show it and I'll have a look.

@DavidAnson commented on GitHub (Dec 19, 2021): Glad you got this sorted out! If there's an example of something not working, please show it and I'll have a look.

kerem commented

2026-03-07 20:05:52 +03:00

Author

Owner

@DavidAnson commented on GitHub (Dec 19, 2021):

I think that's what you did with #469?

@DavidAnson commented on GitHub (Dec 19, 2021): I think that's what you did with #469?

kerem commented

2026-03-07 20:05:52 +03:00

Author

Owner

@adithyabsk commented on GitHub (Dec 19, 2021):

I think that's what you did with #469?

Yep, I was just typing out a message, I think there might be a bug with the way that disable line is handled with front matter. The example is in the PR.

@adithyabsk commented on GitHub (Dec 19, 2021): > I think that's what you did with #469? Yep, I was just typing out a message, I think there might be a bug with the way that disable line is handled with front matter. The example is in the PR.

kerem commented

2026-03-07 20:05:52 +03:00

Author

Owner

@DavidAnson commented on GitHub (Dec 23, 2021):

Closing this, applying the PR in #469.

@DavidAnson commented on GitHub (Dec 23, 2021): Closing this, applying the PR in #469.