mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 17:26:22 +03:00
[GH-ISSUE #443] MD044 flags words in markdown links #2219
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#2219
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @orecham on GitHub (Oct 14, 2021).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/443
The new implementation of MD044 is also flagging proper names in links. e.g.
One might want the following capitalization for GPS:
But then, the following would be flagged as an error:
It looks like the previous version excluded links, which didn't cause this problem: https://github.com/DavidAnson/markdownlint/compare/v0.23.1...v0.24.0#diff-504a7cb2d3155e72bce3746e239ad5d6e4c9836c8e87cf365d0a7a0cb93a6b97L21
@DavidAnson commented on GitHub (Oct 14, 2021):
Is this a widespread problem, or is it just this one case? I agree that capitalization of proper names in links can be different, but it doesn't have to be. That link could use capital letters or you could add that link text as a proper name (ex: "configuring-the-gps.md"). Some scenarios may want the new behavior, so I'd have to add a parameter to disable it. But if this is very rare, I'd be curious what you think about the two options above.
@orecham commented on GitHub (Oct 15, 2021):
I've encountered this problem in a MkDocs project which has about 15-20 instances of it.
Since the file names of the articles are used in URLs when the articles are hosted, it's not so ideal to have proper name capitalization. Hyphenated lowercase is more or less the convention for URLs.
Adding the link text as a proper name is a manageable work-around, but leads to a tedious workflow and "feels" hacky IMO. Some kind of parameter (like the existing
code_blocksone) would be nicer and give a better user experience.@okalachev commented on GitHub (Nov 16, 2021):
Also #435.
MD044 should not check in links and in HTML, I believe.
@DavidAnson commented on GitHub (May 2, 2022):
This should have been fixed by
github.com/DavidAnson/markdownlint@72543a82e7for version0.24.0. For example, the example above does not report a violation.