mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 09:16:02 +03:00
[GH-ISSUE #263] MD028 doesn't differentiate between two blockquotes and one blockquote with a blank line #2075
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#2075
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Mar 2, 2020).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/263
Here's a list of quotes.
This perfectly valid use of Markdown will output the following error :
@DavidAnson commented on GitHub (Mar 2, 2020):
I cannot see the original text you used in the example above, but what you describe sounds exactly like the scenario that MD028 is meant to detect and report on. Please have another look at the rule description, let me know if your situation is different, and show the original Markdown. Thanks!
https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md028---blank-line-inside-blockquote
@ghost commented on GitHub (Mar 3, 2020):
Yes, this is the case. Is there a proposed solution to appropriately display a list of quotes without adding useless text between? Like a double-space on an empty line or something?
@DavidAnson commented on GitHub (Mar 4, 2020):
Would the below approach work?
https://dlaa.me/markdownlint/#%25m%23%20Issue%20263%0A%0A%3E%20Hello%0A%0A%3C!--%20comment%20--%3E%0A%0A%3E%20world%0A
You can also disable that rule, either for the entire project or just the file.
@ghost commented on GitHub (Mar 5, 2020):
That would depend on HTML support, I'm not sure if it's widespread enough. Moreover, it looks a bit more hacky than necessary. Isn't there some more natural way to do it?
I disabled the rule in my own settings, looks like it's an acceptable solution. But then, anyone else opening this file would get the errors, so I'm not so sure about it.
Is this behaviour widespread enough to warrant being in the default settings?
@DavidAnson commented on GitHub (Mar 5, 2020):
You can disable the rule in project settings so that others automatically benefit. I’m not sure how widespread this behavior difference is; the original Ruby implementation predates me. However, many of the original rules were inspired by this document which references the case we are discussing, though it does not address popularity: https://cirosantilli.com/markdown-style-guide#blockquotes
@DavidAnson commented on GitHub (Mar 5, 2020):
This hack also works:
https://dlaa.me/markdownlint/#%25m%23%20Issue%20263%0A%0A%3E%20Hello%0A%0A%5B%5D(ignored)%0A%0A%3E%20world%0A
@ghost commented on GitHub (Mar 5, 2020):
Well then, I guess the solution is to disable it in the user settings when the file is not in a repo. Thanks for the helpful insights!