mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 09:16:02 +03:00
[GH-ISSUE #150] New rule proposal: force emphasis style #1978
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#1978
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @byzyk on GitHub (Oct 15, 2018).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/150
Emphasis (bold text copy) can be written in two ways:
__bold text__or**bold text**.It would be good to force certain emphasis style to keep it consistent.
Please let me know if this could be merged in core repo so I can work on the implementation.
@DavidAnson commented on GitHub (Oct 15, 2018):
This makes sense, thanks. I assume there would also be an option for “consistent“. I’m asking that new rules start externally- more here: https://github.com/DavidAnson/markdownlint/blob/master/CONTRIBUTING.md
@byzyk commented on GitHub (Oct 15, 2018):
@DavidAnson cool, glad to hear that.
I'm going to implement this in our webpack docs first and give you an update on how it went. Gonna keep you posted.
@DavidAnson commented on GitHub (Oct 15, 2018):
Good luck. If you have any questions, let me know and I’ll try to help!
@DavidAnson commented on GitHub (Oct 15, 2018):
Please let me know if the lack of internal helper methods is too annoying: https://github.com/DavidAnson/markdownlint/issues/134
@byzyk commented on GitHub (Oct 29, 2018):
Hey @DavidAnson!
I've come up with a custom rule for emphasis style. It worked pretty well for our case (see CI build failed).
Do you think this is something that can be merged to core repo? Feel free to dig into source code if you want to to check implementation.
I'd be happy to submit a PR shortly with test cases should you decide to give a green light on this one 🙂
@DavidAnson commented on GitHub (Oct 29, 2018):
Great! I’ll be working on markdownlint again soon and will look into this (and shared.js) then.
@DavidAnson commented on GitHub (Apr 15, 2019):
@byzyk: Still interested in putting your rule implementation into the core? I just accepted another PR for a new rule, and am open to yours as well. :)
@byzyk commented on GitHub (Apr 27, 2019):
Hi @DavidAnson, sorry for a bit of a delay
Yes totally! Is there anything I should note before submitting a PR? I assume you'd expect tests for the rule, right?
@DavidAnson commented on GitHub (Apr 27, 2019):
Cool! I’ve been changing the coding style of rules slightly, so please have a look in the
nextbranch to see what I mean. There are two new rules there (one from a contributor) that may be helpful. I’d ask that you send your PR from that branch and, yes, we will need tests before it ultimately goes in. :) It’s pretty quick and easy to add tests for most rules, so I hope that won’t be a big investment. Thanks for your help!PS - I’m thinking to release soon, so if you have something in the next few days it can be in this release. If not, that’s totally fine!
@byzyk commented on GitHub (May 13, 2019):
Hi @DavidAnson, thanks for your guidance, it's really helpful but unfortunately I'm totally swamped at work atm, so not sure on when will I have time to take care of this. Hopefully in a month or so 🤞🏽
@DavidAnson commented on GitHub (May 13, 2019):
Whenever you’re ready!
@TheJaredWilcurt commented on GitHub (Aug 25, 2019):
Also excitedly waiting for this. Especially for enforcing
_text_to be*text*.@mkistler commented on GitHub (Aug 8, 2021):
I was looking for a rule/rules very much like this. To be specific, the rule(s) I want are:
It would be great to have these in the base package!