mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 17:26:22 +03:00
[GH-ISSUE #25] Suggestion: Add rules json schema #19
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mizunashi-mana on GitHub (Jul 30, 2016).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/25
Such as:
From https://raw.githubusercontent.com/DavidAnson/vscode-markdownlint/master/config-schema.json
@DavidAnson commented on GitHub (Jul 30, 2016):
I created that schema because the VS Code extension
vscode-markdownlintcan use it to provide syntax highlighting in the editor (i.e., warning). How are you thinking to use the schema withmarkdownlint? Would you want to throw an exception if the user provides a config that isn't valid? My worry about that would be that it is too restrictive (i.e., error). For example, note that I use the unsupportedcommentkey to add information to the sample styles: https://github.com/DavidAnson/markdownlint/blob/master/style/relaxed.jsonI don't think I would want to block a valid user just because they had extra content in their JSON.
@mizunashi-mana commented on GitHub (Jul 31, 2016):
In this case, json schema permits additional properties on default. So, this is not problem.
However, there might be problems in other cases.
Yet, I think the rules structure of
markdownlintare more complexity than other linter config.For markdownlint developers, we should provide validations.
json-schema is flexible and has many supports. For example, we can nest such as:
ref: https://spacetelescope.github.io/understanding-json-schema/structuring.html
And, related writers can choose best library that suits them from many libraries.
I think providing json schema, providing cost saving and flexible validations for markdownlint tool writers.
@DavidAnson commented on GitHub (Jul 31, 2016):
I think this could work as a new
validateSchemaoption - iftrue, an exception is thrown for an invalid schema. I usetv4invscode-markdownlint, so it would be fairly straightforward to add.However, I'm reluctant to introduce a new
dependenciesfor something non-essential like this. :( (There's currently just one and it's the Markdown parser!) I'd worry less about usingdevDependencies, but I'm not sure that works for the scenario you have in mind.I may need to think about this more.