mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 17:26:22 +03:00
[GH-ISSUE #181] rule MD034 flags URL in Inline code with backticks as "bare url" #156
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#156
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xueqing on GitHub (Apr 28, 2019).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/181
A URL inside of an
inline codewith backticks is marked as a "bare url" by markdownlint.My editor is vscode.
Example:
git clone https://github.com/tensorflow/tensorflow.git@DavidAnson commented on GitHub (Apr 28, 2019):
Thanks, I should be able to look at this soon.
@nschonni commented on GitHub (Apr 29, 2019):
I think it's actually flagging the
# use https://, but I've noticed that the cursor position can sometimes be off on rules in VS Code. EX: Unescaped (MD033) violations usually point to the first element on a line, even if the actual error is with a different element later on in the same line.@xueqing commented on GitHub (Apr 29, 2019):
Thank you for your explanation! It works for me.
@xueqing commented on GitHub (Apr 29, 2019):
It seems it's my comment problem o(╥﹏╥)o
@DavidAnson
@DavidAnson commented on GitHub (Apr 29, 2019):
That’s great to know, thank you both! I think the error and line number are correct, but the highlighting is wrong. I will leave this issue open to look into that.
Some background, in case you are interested: Some rules identify the range themselves and should usually be correct. There are some cases where the VS Code extension does its own range calculation and those are less reliable because they are based on regular expressions.
@DavidAnson commented on GitHub (Apr 29, 2019):
By the way, I am one failing a test case away from improving MD033 in an upcoming commit. It should handle a few more scenarios and highlight better very soon!