mirror of
https://github.com/DavidAnson/markdownlint.git
synced 2026-04-25 09:16:02 +03:00
[GH-ISSUE #168] MD037 triggering for escaped astricks in math equations #146
Labels
No labels
bug
enhancement
enhancement
enhancement
fixed in next
fixed in next
fixed in next
new rule
new rule
new rule
pull-request
question
refactoring
refactoring
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/markdownlint#146
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nschonni on GitHub (Feb 27, 2019).
Original GitHub issue: https://github.com/DavidAnson/markdownlint/issues/168
I'm seeing this triggered from through the Markdownlint (0.12) invoke through Markdownlint-CLI (0.14)
When I open the file in VS Code with the Markdownlint extension, it isn't picked up as an error though
@DavidAnson commented on GitHub (Feb 27, 2019):
This is an issue for igorshubovych/markdownlint-cli which doesn't (yet) recognize math blocks. See
github.com/DavidAnson/vscode-markdownlint@bd71955cf9for how this was implemented in the VS Code extension. I'd thought to confirm it worked correctly in the VS Code extension before updating the CLI.(I'd transfer the issue, but don't seem to be able to do so into someone else's namespace.)
@nschonni commented on GitHub (Feb 27, 2019):
The code itself isn't actually in a code fence so I thought it might be a regex issue here
@DavidAnson commented on GitHub (Feb 27, 2019):
I assumed you just didn’t include the fence. I can have a closer look soon.
@nschonni commented on GitHub (Feb 27, 2019):
Here is one of the files I've hit it on https://github.com/dotnet/docs/blob/master/docs/visual-basic/language-reference/keywords/derived-math-functions.md
Note that it does have some unescaped
*, but I still get the warnings after escaping all the asterisks in the file@DavidAnson commented on GitHub (Feb 28, 2019):
I think this is unrelated to the new math block handling and is a bug in this library. Is there a chance the rule is disabled in your VS Code configuration? I’d expect to see the error reported there as well (though I can’t verify that right now).
@nschonni commented on GitHub (Feb 28, 2019):
I don't have any rules set in my VS Code, but I do have the Docs Authoring Extension that adds these rules https://github.com/Microsoft/vscode-docs-authoring/tree/master/docs-markdown/markdownlint-custom-rules
@DavidAnson commented on GitHub (Mar 1, 2019):
Okay, so this is not showing up in VS Code because the range that markdownlint emits for the error causes an exception when reported by the extension because the starting character is out of range. That breaks linting and nothing else is output. Once fixed in markdownlint, this should start working in the VS Code extension.