[PR #1015] [CLOSED] Add missing parsers property to RuleParams #1164

Closed
opened 2026-03-03 02:02:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/DavidAnson/markdownlint/pull/1015
Author: @Lehoczky
Created: 10/21/2023
Status: Closed

Base: nextHead: next-add-missing-prop


📝 Commits (1)

  • 1aa61e6 Add missing parsers property to RuleParams

📊 Changes

2 files changed (+37 additions, -1 deletions)

View changed files

📝 lib/markdownlint.d.ts (+23 -1)
📝 lib/markdownlint.js (+14 -0)

📄 Description

📚Description

I've found that RuleParams type was missing the parsers property while playing around with the code.

What do you think about using type hints in rule declarations like it is done in ESLint? It would elevate the developer experience when working with rules not just because of the type checking, but because of the added autocompletion and better syntax highlighting:

image
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/DavidAnson/markdownlint/pull/1015 **Author:** [@Lehoczky](https://github.com/Lehoczky) **Created:** 10/21/2023 **Status:** ❌ Closed **Base:** `next` ← **Head:** `next-add-missing-prop` --- ### 📝 Commits (1) - [`1aa61e6`](https://github.com/DavidAnson/markdownlint/commit/1aa61e6f46f86402f52b00f087389bac88b043b1) Add missing `parsers` property to `RuleParams` ### 📊 Changes **2 files changed** (+37 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/markdownlint.d.ts` (+23 -1) 📝 `lib/markdownlint.js` (+14 -0) </details> ### 📄 Description ## 📚Description I've found that `RuleParams` type was missing the `parsers` property while playing around with the code. What do you think about using type hints in rule declarations [like it is done in ESLint](https://github.com/eslint/eslint/blob/main/lib/rules/array-bracket-newline.js#L14)? It would elevate the developer experience when working with rules not just because of the type checking, but because of the added autocompletion and better syntax highlighting: ![image](https://github.com/DavidAnson/markdownlint/assets/31937175/a13afc05-7c0b-4813-8e69-0d02d174c46f) ![image](https://github.com/DavidAnson/markdownlint/assets/31937175/3eff1148-f97f-4c50-81e1-27d588888f22) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 02:02:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/markdownlint#1164
No description provided.