[PR #18] [MERGED] fix: blank iframe issue #99

Closed
opened 2026-03-01 14:40:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/arikchakma/maily.to/pull/18
Author: @moogii
Created: 11/2/2023
Status: Merged
Merged: 11/2/2023
Merged by: @arikchakma

Base: mainHead: fix-iframe-issue


📝 Commits (6)

📊 Changes

4 files changed (+73 additions, -15 deletions)

View changed files

📝 components/app-editor/index.tsx (+1 -1)
📝 components/editor-preview.tsx (+1 -1)
📝 components/iframe.tsx (+34 -13)
utils/detect-browser.ts (+37 -0)

📄 Description

Description

fixes #15
iframe onLoad isn't working

What

  • set inner html in useeffect hook

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/arikchakma/maily.to/pull/18 **Author:** [@moogii](https://github.com/moogii) **Created:** 11/2/2023 **Status:** ✅ Merged **Merged:** 11/2/2023 **Merged by:** [@arikchakma](https://github.com/arikchakma) **Base:** `main` ← **Head:** `fix-iframe-issue` --- ### 📝 Commits (6) - [`0c0ba73`](https://github.com/arikchakma/maily.to/commit/0c0ba7360005efc19c5a4f59c5739608fe0858d9) fix: blank iframe issue - [`ba3a35c`](https://github.com/arikchakma/maily.to/commit/ba3a35c007737fe5519aea77948f8a6cec9b4ee4) fix: clear timeout - [`6f30e31`](https://github.com/arikchakma/maily.to/commit/6f30e3142aecadff94ca40ac85ef50fb290c2d9b) chore: remove timeout - [`45ce48c`](https://github.com/arikchakma/maily.to/commit/45ce48c9fcfe54296b70d52c56ec765432845ead) fix: iframe issue on firefox - [`1ea7799`](https://github.com/arikchakma/maily.to/commit/1ea779946073baeea467fc8b154beff71cbe89d2) Fix `iFrame` browser issue - [`d973d09`](https://github.com/arikchakma/maily.to/commit/d973d09d9c9b8874abe9c648fed34001e8cb7dc8) Merge branch 'fix-iframe-issue' of https://github.com/moogii/maily.to into pr/18 ### 📊 Changes **4 files changed** (+73 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `components/app-editor/index.tsx` (+1 -1) 📝 `components/editor-preview.tsx` (+1 -1) 📝 `components/iframe.tsx` (+34 -13) ➕ `utils/detect-browser.ts` (+37 -0) </details> ### 📄 Description ## Description fixes #15 iframe [onLoad](https://stackoverflow.com/questions/12076494/onload-in-iframes-not-working-if-iframe-have-non-html-document-in-src-pdf-or-t/12190776#12190776) isn't working ### What - set inner html in useeffect hook --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:40:04 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/maily.to#99
No description provided.