[PR #20] [MERGED] Implement Variable Formatter & Fallback #97

New issue

Closed

opened 2026-03-01 14:40:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:40:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/arikchakma/maily.to/pull/20
Author: @arikchakma
Created: 12/2/2023
Status: ✅ Merged
Merged: 12/3/2023
Merged by: @arikchakma

Base: main ← Head: feat/variable

📝 Commits (10+)

5bd84ea Add variable suggestions
ba54aa6 Add Extension extender
c7ac7f3 Initial Variable Component
cb9b834 Implement Variable popover
6788133 Implement Variable Formatter
2e2a4b6 Update Email To
ec768fa Image Url update menu
ae36fa5 Fix re-rendering
b3acc5f Add tests for variables
e233023 Add test for formatter

📊 Changes

18 files changed (+676 additions, -195 deletions)

View changed files

📝 apps/web/actions/email.ts (+18 -9)
📝 packages/core/package.json (+1 -3)
📝 packages/core/src/editor/components/editor-bubble-menu.tsx (+2 -0)
📝 packages/core/src/editor/components/image-bubble-menu.tsx (+33 -9)
📝 packages/core/src/editor/extensions/button-extension.ts (+1 -1)
📝 packages/core/src/editor/extensions/index.ts (+52 -41)
📝 packages/core/src/editor/extensions/slash-command.tsx (+4 -0)
➕ packages/core/src/editor/extensions/variable-extension.ts (+191 -0)
📝 packages/core/src/editor/index.tsx (+10 -3)
📝 packages/core/src/editor/nodes/button.tsx (+1 -1)
📝 packages/core/src/editor/nodes/variable.tsx (+194 -95)
📝 packages/render/package.json (+1 -0)
📝 packages/render/src/index.ts (+1 -0)
📝 packages/render/src/maily.tsx (+67 -31)
📝 packages/render/src/render-async.ts (+2 -1)
📝 packages/render/src/render.test.ts (+85 -0)
📝 packages/render/src/render.ts (+2 -1)
📝 pnpm-lock.yaml (+11 -0)

📄 Description

Fix sending to multiple recipients.
Implement variable popover to update the fallback value.
Add variableFormatter, and variableValues in the compiler.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/arikchakma/maily.to/pull/20 **Author:** [@arikchakma](https://github.com/arikchakma) **Created:** 12/2/2023 **Status:** ✅ Merged **Merged:** 12/3/2023 **Merged by:** [@arikchakma](https://github.com/arikchakma) **Base:** `main` ← **Head:** `feat/variable` --- ### 📝 Commits (10+) - [`5bd84ea`](https://github.com/arikchakma/maily.to/commit/5bd84eaebd213a84cd1378c8770b40b33f681bb1) Add variable suggestions - [`ba54aa6`](https://github.com/arikchakma/maily.to/commit/ba54aa62da9e629af2be10bb77d04be369233ba0) Add Extension extender - [`c7ac7f3`](https://github.com/arikchakma/maily.to/commit/c7ac7f370c223a64d3f1227b49453b6741fea36b) Initial Variable Component - [`cb9b834`](https://github.com/arikchakma/maily.to/commit/cb9b8345ec50dbf08b151226fc96e48e622ad40a) Implement Variable popover - [`6788133`](https://github.com/arikchakma/maily.to/commit/678813385d0d88a47da608e61736a8490030ee7a) Implement Variable Formatter - [`2e2a4b6`](https://github.com/arikchakma/maily.to/commit/2e2a4b69e54cca3836782f4420eb71b2a7620834) Update Email To - [`ec768fa`](https://github.com/arikchakma/maily.to/commit/ec768faf9261f6324ac98a4ccd0fe6f11afac956) Image Url update menu - [`ae36fa5`](https://github.com/arikchakma/maily.to/commit/ae36fa5ff4e6d50471b13b4d8535ef61c07a9a34) Fix re-rendering - [`b3acc5f`](https://github.com/arikchakma/maily.to/commit/b3acc5f178287d49bbb3884a54c6e17f05c6a29b) Add tests for variables - [`e233023`](https://github.com/arikchakma/maily.to/commit/e2330232e70c7f4228f4c3b2dd18b5f90f608ca7) Add test for formatter ### 📊 Changes **18 files changed** (+676 additions, -195 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/actions/email.ts` (+18 -9) 📝 `packages/core/package.json` (+1 -3) 📝 `packages/core/src/editor/components/editor-bubble-menu.tsx` (+2 -0) 📝 `packages/core/src/editor/components/image-bubble-menu.tsx` (+33 -9) 📝 `packages/core/src/editor/extensions/button-extension.ts` (+1 -1) 📝 `packages/core/src/editor/extensions/index.ts` (+52 -41) 📝 `packages/core/src/editor/extensions/slash-command.tsx` (+4 -0) ➕ `packages/core/src/editor/extensions/variable-extension.ts` (+191 -0) 📝 `packages/core/src/editor/index.tsx` (+10 -3) 📝 `packages/core/src/editor/nodes/button.tsx` (+1 -1) 📝 `packages/core/src/editor/nodes/variable.tsx` (+194 -95) 📝 `packages/render/package.json` (+1 -0) 📝 `packages/render/src/index.ts` (+1 -0) 📝 `packages/render/src/maily.tsx` (+67 -31) 📝 `packages/render/src/render-async.ts` (+2 -1) 📝 `packages/render/src/render.test.ts` (+85 -0) 📝 `packages/render/src/render.ts` (+2 -1) 📝 `pnpm-lock.yaml` (+11 -0) </details> ### 📄 Description - [x] Fix sending to multiple recipients. - [x] Implement `variable` popover to update the `fallback` value. - [x] Add `variableFormatter`, and `variableValues` in the compiler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>