mirror of
https://github.com/arikchakma/maily.to.git
synced 2026-04-25 22:25:51 +03:00
[GH-ISSUE #113] Remove variable content feature #268
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/maily.to#268
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @woodhull on GitHub (Jan 22, 2025).
Original GitHub issue: https://github.com/arikchakma/maily.to/issues/113
We'd like to remove the current variable content feature. Is there a straightforward way to hide it without forking the library?
In the future, we're likely to implement a different strategy for inserting variables, but currently it doesn't seem like you can turn off the "Show Conditionally" feature on blocks easily.
If this does not exist, is this something you'd be interested in?
Nathan
@arikchakma commented on GitHub (Jan 22, 2025):
Sorry? Which variable content are you taking about?
@woodhull commented on GitHub (Jan 23, 2025):
This feature:
I'm not sure how to turn it off.
@arikchakma commented on GitHub (Jan 23, 2025):
We can do it in a config, but currently there is no way to turn it off.
@woodhull commented on GitHub (Jan 25, 2025):
I've removed this feature in my fork, if there is a future extensions API that will support this sort of modification, I can write a PR against that.
Our motivation here so you're across the context of what we're up to:
We have an existing personalization engine that runs server-side using liquid templates. We're likely to extend the editor to support tiptap marks for liquid tags and add some way to insert liquid variables from the bubble menu.
We're also not using the render functionality of maily.to, but instead translating the tiptap document into mjml for rendering. I may extract the ruby code that does the tiptap nodes => mjml transformation into a ruby gem in case anyone else needs to do something similar.
Not looking for y'all to support our divergent use-case for a nice editor UI but if we can re-use code in core that seems like a win for everyone.
@arikchakma commented on GitHub (Jan 25, 2025):
I will add the modification in the extension API, simplifying the process. Please let me know what you think. You can schedule a meeting to talk about it more.
@woodhull commented on GitHub (Apr 29, 2025):
If we wrote the code to turn this off as a setting would it be accepted?
@arikchakma commented on GitHub (Apr 29, 2025):
I would love to see your solution. It should be a config option. It would be helpful if you guys could do it.