mirror of
https://github.com/arikchakma/maily.to.git
synced 2026-04-25 22:25:51 +03:00
[GH-ISSUE #39] Finding an Alternative to window.prompt #247
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/maily.to#247
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AustinWildgrube on GitHub (Jan 23, 2024).
Original GitHub issue: https://github.com/arikchakma/maily.to/issues/39
Originally assigned to: @arikchakma on GitHub.
Hey,
Love the editor so far! Thanks for all the hard work. I hope to be able to contribute in the future once work settles down for me. I am having an issue, though, and would like to bring it to your attention. Currently, the use of window.prompt is a simple solution, but it might not be the most effective in all situations. For instance, users with pop-ups disabled or those who accidentally activate the "Don't allow this page to display" option might find that nothing happens when they click the image component. This could lead to confusion, as it may seem like the application is not functioning correctly.
Maybe an alternative approach should be considered, such as using a popover similar to the button component. This could provide a more user-friendly experience, especially for those with certain browser settings that interfere with pop-ups. I'm open to discussion and looking forward to your thoughts on this.
Here's a video of what I mean:
https://github.com/arikchakma/maily.to/assets/40448411/66a39824-88df-4cb8-9456-a99fd0a3f07c
@arikchakma commented on GitHub (Jan 23, 2024):
Ah, good catch. I'll add the popup way directly then or maybe a sidebar to edit and add.
@arikchakma commented on GitHub (May 12, 2024):
@AustinWildgrube we have decided not to implement it now as we've planned to make the editor more customizable where we will solve it easily.