[PR #138] [MERGED] feat: variable suggestions popover #181

New issue

Closed

opened 2026-03-01 14:40:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:40:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/arikchakma/maily.to/pull/138
Author: @arikchakma
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @arikchakma

Base: main ← Head: feat/variable-suggestion

📝 Commits (4)

36e6e3b feat: variable suggestions popover
4f294a0 feat: variable options
f9cb18c Merge branch 'main' into feat/variable-suggestion
e0c45f2 docs: variable options

📊 Changes

17 files changed (+388 additions, -349 deletions)

View changed files

📝 packages/core/readme.md (+36 -30)
📝 packages/core/src/editor/components/repeat-menu/repeat-bubble-menu.tsx (+5 -6)
📝 packages/core/src/editor/components/show-popover.tsx (+5 -3)
📝 packages/core/src/editor/components/ui/input-autocomplete.tsx (+11 -8)
📝 packages/core/src/editor/components/ui/link-input-popover.tsx (+13 -20)
📝 packages/core/src/editor/extensions/index.tsx (+2 -7)
📝 packages/core/src/editor/index.tsx (+1 -14)
📝 packages/core/src/editor/nodes/button/button-label-input.tsx (+11 -16)
📝 packages/core/src/editor/nodes/button/button-view.tsx (+5 -6)
➖ packages/core/src/editor/nodes/variable/variable-popover.tsx (+0 -159)
➕ packages/core/src/editor/nodes/variable/variable-suggestions-popover.tsx (+164 -0)
📝 packages/core/src/editor/nodes/variable/variable-suggestions.tsx (+19 -15)
📝 packages/core/src/editor/nodes/variable/variable-view.tsx (+14 -7)
📝 packages/core/src/editor/nodes/variable/variable.ts (+68 -8)
📝 packages/core/src/editor/provider.tsx (+1 -49)
➕ packages/core/src/editor/utils/node-options.ts (+28 -0)
📝 packages/core/src/editor/utils/variable.ts (+5 -1)

📄 Description

This is how it should be used

import { forwardRef, useImperativeHandle } from 'react';
import type { VariableSuggestionPopoverType } from '@maily-to/core';

export const VariableSuggestionPopoverComponent: VariableSuggestionPopoverType =
  forwardRef((props, ref) => {
    const { items, onSelectItem } = props;

    useImperativeHandle(ref, () => ({
      moveUp: () => {},
      moveDown: () => {},
      select: () => {},
    }));

    return <div>Hello</div>;
  });

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/arikchakma/maily.to/pull/138 **Author:** [@arikchakma](https://github.com/arikchakma) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@arikchakma](https://github.com/arikchakma) **Base:** `main` ← **Head:** `feat/variable-suggestion` --- ### 📝 Commits (4) - [`36e6e3b`](https://github.com/arikchakma/maily.to/commit/36e6e3b8c080798a8771b06fcd88ff61f4b27a48) feat: variable suggestions popover - [`4f294a0`](https://github.com/arikchakma/maily.to/commit/4f294a00cf27a83954ce1923ab3257e3166218c0) feat: variable options - [`f9cb18c`](https://github.com/arikchakma/maily.to/commit/f9cb18c175639563eb5b19e8e325d4a50a81ab84) Merge branch 'main' into feat/variable-suggestion - [`e0c45f2`](https://github.com/arikchakma/maily.to/commit/e0c45f24ffa544298d1f891fb0e564899bc07ec8) docs: variable options ### 📊 Changes **17 files changed** (+388 additions, -349 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/readme.md` (+36 -30) 📝 `packages/core/src/editor/components/repeat-menu/repeat-bubble-menu.tsx` (+5 -6) 📝 `packages/core/src/editor/components/show-popover.tsx` (+5 -3) 📝 `packages/core/src/editor/components/ui/input-autocomplete.tsx` (+11 -8) 📝 `packages/core/src/editor/components/ui/link-input-popover.tsx` (+13 -20) 📝 `packages/core/src/editor/extensions/index.tsx` (+2 -7) 📝 `packages/core/src/editor/index.tsx` (+1 -14) 📝 `packages/core/src/editor/nodes/button/button-label-input.tsx` (+11 -16) 📝 `packages/core/src/editor/nodes/button/button-view.tsx` (+5 -6) ➖ `packages/core/src/editor/nodes/variable/variable-popover.tsx` (+0 -159) ➕ `packages/core/src/editor/nodes/variable/variable-suggestions-popover.tsx` (+164 -0) 📝 `packages/core/src/editor/nodes/variable/variable-suggestions.tsx` (+19 -15) 📝 `packages/core/src/editor/nodes/variable/variable-view.tsx` (+14 -7) 📝 `packages/core/src/editor/nodes/variable/variable.ts` (+68 -8) 📝 `packages/core/src/editor/provider.tsx` (+1 -49) ➕ `packages/core/src/editor/utils/node-options.ts` (+28 -0) 📝 `packages/core/src/editor/utils/variable.ts` (+5 -1) </details> ### 📄 Description This is how it should be used ```tsx import { forwardRef, useImperativeHandle } from 'react'; import type { VariableSuggestionPopoverType } from '@maily-to/core'; export const VariableSuggestionPopoverComponent: VariableSuggestionPopoverType = forwardRef((props, ref) => { const { items, onSelectItem } = props; useImperativeHandle(ref, () => ({ moveUp: () => {}, moveDown: () => {}, select: () => {}, })); return <div>Hello</div>; }); ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>