[PR #135] [MERGED] fix: missing className prefix & bubble menu covering issue #178

New issue

Closed

opened 2026-03-01 14:40:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:40:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/arikchakma/maily.to/pull/135
Author: @nygmaaa
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @arikchakma

Base: main ← Head: main

📝 Commits (2)

7a34cad add prefix
95658b6 fix inline image bubble menu get covered by section's

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 packages/core/src/editor/components/section-menu/section-bubble-menu.tsx (+8 -0)
📝 packages/core/src/editor/components/ui/select.tsx (+2 -2)

📄 Description

Fixed two issues:

Missing className prefix for relative and sr-only in packages/core/src/editor/components/ui/select.tsx, which caused the sr-only element to be shown.
Fixed Inline Image bubble menu getting covered by the Section bubble menu when the Inline Image is the first element of the Section.

Reproduction:

Codesandbox: https://codesandbox.io/p/devbox/l359f8?file=%2Fsrc%2FApp.tsx
Screenshot:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/arikchakma/maily.to/pull/135 **Author:** [@nygmaaa](https://github.com/nygmaaa) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@arikchakma](https://github.com/arikchakma) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`7a34cad`](https://github.com/arikchakma/maily.to/commit/7a34cad0635ec4ad3a21de4ee9f690367e83f2e2) add prefix - [`95658b6`](https://github.com/arikchakma/maily.to/commit/95658b6b63904752c77c53c307287e9587ba5108) fix inline image bubble menu get covered by section's ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/editor/components/section-menu/section-bubble-menu.tsx` (+8 -0) 📝 `packages/core/src/editor/components/ui/select.tsx` (+2 -2) </details> ### 📄 Description Fixed two issues: 1. Missing `className` prefix for `relative` and `sr-only` in `packages/core/src/editor/components/ui/select.tsx`, which caused the `sr-only` element to be shown. 2. Fixed `Inline Image` bubble menu getting covered by the `Section` bubble menu when the `Inline Image` is the first element of the `Section`. Reproduction: * Codesandbox: https://codesandbox.io/p/devbox/l359f8?file=%2Fsrc%2FApp.tsx * Screenshot: <img width="697" alt="image" src="https://github.com/user-attachments/assets/df16d2b0-a8f6-4188-b73b-62f4ff991047" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>