[PR #92] [MERGED] feat: add variable in links and button label #146

New issue

Closed

opened 2026-03-01 14:40:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:40:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/arikchakma/maily.to/pull/92
Author: @arikchakma
Created: 12/21/2024
Status: ✅ Merged
Merged: 12/22/2024
Merged by: @arikchakma

Base: main ← Head: feat/text-variables

📝 Commits (8)

8e2eb96 wip
f88ef7c wip
c19e312 wip
6186146 feat: add isVariable to links
7b642f5 feat: variable links
7e22326 Merge branch 'main' into feat/text-variables
5394367 fix: remove protocol if it's variable
9046675 fix: enter trigger

📊 Changes

21 files changed (+538 additions, -153 deletions)

View changed files

📝 packages/core/src/editor/components/for-menu/for-bubble-menu.tsx (+4 -1)
📝 packages/core/src/editor/components/image-menu/image-bubble-menu.tsx (+24 -5)
📝 packages/core/src/editor/components/image-menu/use-image-state.tsx (+19 -14)
📝 packages/core/src/editor/components/show-popover.tsx (+2 -1)
📝 packages/core/src/editor/components/text-menu/text-bubble-menu.tsx (+4 -1)
📝 packages/core/src/editor/components/text-menu/use-text-menu-state.tsx (+2 -1)
📝 packages/core/src/editor/components/ui/input-autocomplete.tsx (+15 -9)
📝 packages/core/src/editor/components/ui/link-input-popover.tsx (+121 -52)
📝 packages/core/src/editor/extensions/index.ts (+2 -2)
➕ packages/core/src/editor/nodes/button/button-label-input.tsx (+88 -0)
📝 packages/core/src/editor/nodes/button/button-view.tsx (+18 -15)
📝 packages/core/src/editor/nodes/button/button.tsx (+35 -0)
📝 packages/core/src/editor/nodes/image/image-view.tsx (+22 -6)
📝 packages/core/src/editor/nodes/image/image.ts (+41 -0)
➕ packages/core/src/editor/nodes/link.ts (+31 -0)
📝 packages/core/src/editor/nodes/logo/logo-view.tsx (+7 -3)
📝 packages/core/src/editor/nodes/logo/logo.ts (+20 -0)
📝 packages/core/src/editor/nodes/variable/variable-suggestions.tsx (+11 -5)
📝 packages/core/src/editor/nodes/variable/variable-view.tsx (+2 -18)
📝 packages/core/src/editor/nodes/variable/variable.ts (+10 -0)

...and 1 more files

📄 Description

Block	Attribute	Static Text	Variables
Button	label	✅	✅
Button	external link	✅	✅
Image & Logo	source link	✅	✅
Image & Logo	external link	✅	✅
For	each	❌	✅
	Show If	❌	✅
Normal Link	href	✅	✅

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/arikchakma/maily.to/pull/92 **Author:** [@arikchakma](https://github.com/arikchakma) **Created:** 12/21/2024 **Status:** ✅ Merged **Merged:** 12/22/2024 **Merged by:** [@arikchakma](https://github.com/arikchakma) **Base:** `main` ← **Head:** `feat/text-variables` --- ### 📝 Commits (8) - [`8e2eb96`](https://github.com/arikchakma/maily.to/commit/8e2eb96f6486e87f48b7d9eabbc0e2d95aecb54c) wip - [`f88ef7c`](https://github.com/arikchakma/maily.to/commit/f88ef7c4710a71218d065a282f3924ac2c1cd4d5) wip - [`c19e312`](https://github.com/arikchakma/maily.to/commit/c19e312cf50f1faa73a828e37a05710f9ab57afb) wip - [`6186146`](https://github.com/arikchakma/maily.to/commit/6186146098cb3f1dfd3ee8f878a82dbdc0d251d3) feat: add `isVariable` to links - [`7b642f5`](https://github.com/arikchakma/maily.to/commit/7b642f5a7a39a5780080aecc740efe7e4d4e26a8) feat: variable links - [`7e22326`](https://github.com/arikchakma/maily.to/commit/7e2232653001843d25e15a3bdbc32ab1f3462157) Merge branch 'main' into feat/text-variables - [`5394367`](https://github.com/arikchakma/maily.to/commit/5394367e15076abfa95820fce546ed4adba2af84) fix: remove protocol if it's variable - [`9046675`](https://github.com/arikchakma/maily.to/commit/904667524ec835dfac7ae81c8f12d6dba91b13fb) fix: enter trigger ### 📊 Changes **21 files changed** (+538 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/editor/components/for-menu/for-bubble-menu.tsx` (+4 -1) 📝 `packages/core/src/editor/components/image-menu/image-bubble-menu.tsx` (+24 -5) 📝 `packages/core/src/editor/components/image-menu/use-image-state.tsx` (+19 -14) 📝 `packages/core/src/editor/components/show-popover.tsx` (+2 -1) 📝 `packages/core/src/editor/components/text-menu/text-bubble-menu.tsx` (+4 -1) 📝 `packages/core/src/editor/components/text-menu/use-text-menu-state.tsx` (+2 -1) 📝 `packages/core/src/editor/components/ui/input-autocomplete.tsx` (+15 -9) 📝 `packages/core/src/editor/components/ui/link-input-popover.tsx` (+121 -52) 📝 `packages/core/src/editor/extensions/index.ts` (+2 -2) ➕ `packages/core/src/editor/nodes/button/button-label-input.tsx` (+88 -0) 📝 `packages/core/src/editor/nodes/button/button-view.tsx` (+18 -15) 📝 `packages/core/src/editor/nodes/button/button.tsx` (+35 -0) 📝 `packages/core/src/editor/nodes/image/image-view.tsx` (+22 -6) 📝 `packages/core/src/editor/nodes/image/image.ts` (+41 -0) ➕ `packages/core/src/editor/nodes/link.ts` (+31 -0) 📝 `packages/core/src/editor/nodes/logo/logo-view.tsx` (+7 -3) 📝 `packages/core/src/editor/nodes/logo/logo.ts` (+20 -0) 📝 `packages/core/src/editor/nodes/variable/variable-suggestions.tsx` (+11 -5) 📝 `packages/core/src/editor/nodes/variable/variable-view.tsx` (+2 -18) 📝 `packages/core/src/editor/nodes/variable/variable.ts` (+10 -0) _...and 1 more files_ </details> ### 📄 Description | Block | Attribute | Static Text | Variables | |---------------|-----------------|-------------|-----------| | Button | label | ✅ | ✅ | | Button | external link | ✅ | ✅ | | Image & Logo | source link | ✅ | ✅ | | Image & Logo | external link | ✅ | ✅ | | For | each | ❌ | ✅ | | | Show If | ❌ | ✅ | | Normal Link | href | ✅ | ✅ | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>