[PR #82] [MERGED] fix: bubble menu #137

New issue

Closed

opened 2026-03-01 14:40:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:40:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/arikchakma/maily.to/pull/82
Author: @arikchakma
Created: 12/7/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @arikchakma

Base: main ← Head: fix/bubble

📝 Commits (5)

c93a0e5 fix: hide text bubble menu
3d3609f fix: show specific bubble menu
835f10e fix: button outline
3c2e25c fix: select on sidebar click
f88dd02 fix: enter capturing

📊 Changes

11 files changed (+66 additions, -45 deletions)

View changed files

📝 packages/core/src/editor/components/alignment-switch.tsx (+1 -1)
📝 packages/core/src/editor/components/base-button.tsx (+1 -1)
📝 packages/core/src/editor/components/for-menu/for-bubble-menu.tsx (+15 -5)
📝 packages/core/src/editor/components/section-menu/section-bubble-menu.tsx (+24 -27)
📝 packages/core/src/editor/components/show-popover.tsx (+1 -1)
📝 packages/core/src/editor/components/ui/select.tsx (+2 -2)
📝 packages/core/src/editor/extensions/index.ts (+4 -4)
📝 packages/core/src/editor/nodes/columns/column.ts (+1 -1)
📝 packages/core/src/editor/nodes/columns/columns.ts (+1 -1)
📝 packages/core/src/editor/nodes/for/for-view.tsx (+8 -2)
📝 packages/core/src/editor/utils/is-custom-node-selected.ts (+8 -0)

📄 Description

Show appropriate bubble menus for each node
Remove the Text bubble menu when deleting
Fix Outline Z index issue
Add select outline on focus
Select For on sidebar click

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/arikchakma/maily.to/pull/82 **Author:** [@arikchakma](https://github.com/arikchakma) **Created:** 12/7/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@arikchakma](https://github.com/arikchakma) **Base:** `main` ← **Head:** `fix/bubble` --- ### 📝 Commits (5) - [`c93a0e5`](https://github.com/arikchakma/maily.to/commit/c93a0e5bd6ad73473ed851cbf34c0fc4b78b24f6) fix: hide text bubble menu - [`3d3609f`](https://github.com/arikchakma/maily.to/commit/3d3609ff3c7eea6f6c98ba8cdfcce80ae33b8748) fix: show specific bubble menu - [`835f10e`](https://github.com/arikchakma/maily.to/commit/835f10e061060f727862ff7576ea54b4d8675635) fix: button outline - [`3c2e25c`](https://github.com/arikchakma/maily.to/commit/3c2e25cd8c57fd020a64e66970f8cebc987149a6) fix: select on sidebar click - [`f88dd02`](https://github.com/arikchakma/maily.to/commit/f88dd0223854acf7efd55b8451c19923ed9b74d2) fix: enter capturing ### 📊 Changes **11 files changed** (+66 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/editor/components/alignment-switch.tsx` (+1 -1) 📝 `packages/core/src/editor/components/base-button.tsx` (+1 -1) 📝 `packages/core/src/editor/components/for-menu/for-bubble-menu.tsx` (+15 -5) 📝 `packages/core/src/editor/components/section-menu/section-bubble-menu.tsx` (+24 -27) 📝 `packages/core/src/editor/components/show-popover.tsx` (+1 -1) 📝 `packages/core/src/editor/components/ui/select.tsx` (+2 -2) 📝 `packages/core/src/editor/extensions/index.ts` (+4 -4) 📝 `packages/core/src/editor/nodes/columns/column.ts` (+1 -1) 📝 `packages/core/src/editor/nodes/columns/columns.ts` (+1 -1) 📝 `packages/core/src/editor/nodes/for/for-view.tsx` (+8 -2) 📝 `packages/core/src/editor/utils/is-custom-node-selected.ts` (+8 -0) </details> ### 📄 Description - [x] Show appropriate bubble menus for each node - [x] Remove the Text bubble menu when deleting - [x] Fix Outline Z index issue - [x] Add select outline on focus - [x] Select For on sidebar click --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>