mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 00:35:51 +03:00
[GH-ISSUE #147] MP_WEBROOT is ignored in the API-Documentation #99
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#99
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @christian-scheible on GitHub (Jul 25, 2023).
Original GitHub issue: https://github.com/axllent/mailpit/issues/147
I have set MP_WEBROOT to mailcatcher. However when I am visiting http://localhost/mailcatcher/api/v1/ the documentation shows:
API Server http://localhost
and if I try to test a request using the TRY button, the request fails as it doesn't append mailcatcher to the request.
So it tries
http://localhost/api/v1/infoinstead ofhttp://localhost/mailcatcher/api/v1/info@axllent commented on GitHub (Jul 25, 2023):
You are absolutely right - currently the swagger config does not take the current webroot into consideration. I'll need to think of a solution for this as the
swagger.jsonspec file for the API (used in the docs you are referring to) is embedded in the application, and not dynamically generated based on startup arguments.@christian-scheible commented on GitHub (Jul 25, 2023):
@axllent, that was quick, thank you! It's not a blocker for me, as I am now using Postman to explore the API. However, I believe honoring the environment variable would make it easier for other users.
@axllent commented on GitHub (Jul 30, 2023):
@christian-scheible This should be fixed now in the latest release 🚀 Please feel free to re-open this ticket if it's not working as you expected.
@christian-scheible commented on GitHub (Jul 31, 2023):
@axllent Thank you for the quick solution. It is now working as expected.