mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 00:35:51 +03:00
[PR #378] [MERGED] UI: Make multiple item selection work on macOS #541
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#541
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/axllent/mailpit/pull/378
Author: @twobiers
Created: 10/23/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @axllent
Base:
feature/multi-select-macos← Head:develop📝 Commits (2)
62c7a34UI: Make multiple tag selection work on macOSe052a09UI: Allow click+meta key combination to select messages in list📊 Changes
2 files changed (+4 additions, -3 deletions)
View changed files
📝
server/ui-src/components/ListMessages.vue(+2 -1)📝
server/ui-src/components/NavTags.vue(+2 -2)📄 Description
The Feature to select multiple tags in the UI (#216) does not work properly on macOS. The problem is that on MacOS, the Ctrl key is typically used in conjunction with other keys, such as the Cmd key, to perform system-level functions. As a result, the Ctrl key is not always recognized as a modifier key in Vue.js applications.
This change introduces the usage of the mod key as a fallback, as there is currently no nice way to select between Ctrl/Mod based on the platform. See https://github.com/vuejs/vue/issues/4843 for discussion.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.