mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 00:35:51 +03:00
[GH-ISSUE #82] Docker version tag for major/minor version branch #54
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#54
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ocean90 on GitHub (Apr 3, 2023).
Original GitHub issue: https://github.com/axllent/mailpit/issues/82
Right now the Docker images are only available via the
latestand the specific version tags. It would be helpful to be able to only defineaxllent/mailpit:v1.5which would pull the latest version of the1.5branch. That would be1.5.4at the moment.It seems like this only needs a change to
github.com/axllent/mailpit@8e84b96233/.github/workflows/build-docker.yml (L34)Maybe the docker/metadata-action action will be useful: https://github.com/docker/metadata-action#typesemver
@axllent commented on GitHub (Apr 3, 2023):
Thanks for the suggestion, this is a good idea. I think that the docker/metadata-action is probably an overkill as it is designed to also push images (I just need to work out that the major.minor version is), so I'm going to try another simpler action first. Assuming this works (you never know until you try), the next release should include a
mailpit:v1.5tag 👍 I will leave this open until the next release (which are fairly regular).@ocean90 commented on GitHub (Apr 3, 2023):
Sounds good! I don't think it will be push stuff as it only provides an output for the metadata which can be used by the push action. The readme has a good example for this.
@axllent commented on GitHub (Apr 4, 2023):
I've tested this on a separate testing repo and the action I am using to detect the major/minor version is working as expected. Given there are no current changes it may be a while before another release, so in the interim I have manually pushed a v1.5 tag (identical currently to v1.5.4) so you can start using that already if you like. When newer v1.5.* releases are created, the v1.5 tag will be updated, then v.16 will get added and updated etc when the release tags reach v1.6.* etc.
I'll close this ticket as it is effectively done now (just waiting for more releases). Thanks again for the suggestion.