[PR #312] [MERGED] Changed POP3 size output to show compatible size #512

New issue

Closed

opened 2026-03-15 14:23:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 14:23:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/axllent/mailpit/pull/312
Author: @antonionardella
Created: 6/13/2024
Status: ✅ Merged
Merged: 6/14/2024
Merged by: @axllent

Base: develop ← Head: develop

📝 Commits (2)

71e45db Changed POP3 size output to show compatible size
dcca1f5 Setting POP3 10 minutes timeout according to RFC1939

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server/pop3/pop3.go (+2 -2)

📄 Description

This commit makes sure that LIST shows an RFC1939 compatible size

LIST
+OK 1 messages (5833 octets)
1 5833

Instead of

LIST
+OK 5 messages (27300 octets)
1 %!d(float64=5461)
2 %!d(float64=5465)
3 %!d(float64=5350)
4 %!d(float64=5349)
5 %!d(float64=5675)

And fixes the float64=5461 error of this issue https://github.com/axllent/mailpit/issues/311#issuecomment-2165453243

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/axllent/mailpit/pull/312 **Author:** [@antonionardella](https://github.com/antonionardella) **Created:** 6/13/2024 **Status:** ✅ Merged **Merged:** 6/14/2024 **Merged by:** [@axllent](https://github.com/axllent) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`71e45db`](https://github.com/axllent/mailpit/commit/71e45dbf0ead14bc15fc999a8ae8dc2a27816fa5) Changed POP3 size output to show compatible size - [`dcca1f5`](https://github.com/axllent/mailpit/commit/dcca1f553880b31282f9951f484023935f123aea) Setting POP3 10 minutes timeout according to RFC1939 ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/pop3/pop3.go` (+2 -2) </details> ### 📄 Description This commit makes sure that LIST shows an RFC1939 compatible size ``` LIST +OK 1 messages (5833 octets) 1 5833 ``` Instead of ``` LIST +OK 5 messages (27300 octets) 1 %!d(float64=5461) 2 %!d(float64=5465) 3 %!d(float64=5350) 4 %!d(float64=5349) 5 %!d(float64=5675) ``` And fixes the `float64=5461` error of this issue https://github.com/axllent/mailpit/issues/311#issuecomment-2165453243 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>