[GH-ISSUE #64] Invalid chars in webroot too strict #39

Closed
opened 2026-03-15 12:13:52 +03:00 by kerem · 2 comments
Owner

Originally created by @adepretis on GitHub (Mar 9, 2023).
Original GitHub issue: https://github.com/axllent/mailpit/issues/64

I think the invalid char list for the webroot is a bit too strict. Currently only [^0-9a-zA-Z\/-] is supported but I think there should be at least _ allowed too.

For example when hooking Mailhog into an "internal path" that has special access rights, even in non-production environments. For example https://my.service/_internal/mailpit.

Would it be possible to add at least _ to the list of allowed chars? Maybe also . would make sense - think https://my.service/internal.mailpit

Originally created by @adepretis on GitHub (Mar 9, 2023). Original GitHub issue: https://github.com/axllent/mailpit/issues/64 I think the invalid char list for the webroot is a bit too strict. Currently only `[^0-9a-zA-Z\/-]` is supported but I think there should be at least `_` allowed too. For example when hooking Mailhog into an "internal path" that has special access rights, even in non-production environments. For example https://my.service/_internal/mailpit. Would it be possible to add at least `_` to the list of allowed chars? Maybe also `.` would make sense - think https://my.service/internal.mailpit
kerem closed this issue 2026-03-15 12:13:57 +03:00
Author
Owner

@axllent commented on GitHub (Mar 10, 2023):

@adepretis Thank you for raising this - adding those characters is not a problem at all. Both _ and . characters will be included in the next release.

<!-- gh-comment-id:1463086523 --> @axllent commented on GitHub (Mar 10, 2023): @adepretis Thank you for raising this - adding those characters is not a problem at all. Both `_` and `.` characters will be included in the next release.
Author
Owner

@axllent commented on GitHub (Mar 10, 2023):

This has been included in the v.1.3.11 release. Thank you for your contribution.

<!-- gh-comment-id:1463121954 --> @axllent commented on GitHub (Mar 10, 2023): This has been included in the v.1.3.11 release. Thank you for your contribution.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/mailpit#39
No description provided.