mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 08:45:54 +03:00
[GH-ISSUE #64] Invalid chars in webroot too strict #39
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#39
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adepretis on GitHub (Mar 9, 2023).
Original GitHub issue: https://github.com/axllent/mailpit/issues/64
I think the invalid char list for the webroot is a bit too strict. Currently only
[^0-9a-zA-Z\/-]is supported but I think there should be at least_allowed too.For example when hooking Mailhog into an "internal path" that has special access rights, even in non-production environments. For example https://my.service/_internal/mailpit.
Would it be possible to add at least
_to the list of allowed chars? Maybe also.would make sense - think https://my.service/internal.mailpit@axllent commented on GitHub (Mar 10, 2023):
@adepretis Thank you for raising this - adding those characters is not a problem at all. Both
_and.characters will be included in the next release.@axllent commented on GitHub (Mar 10, 2023):
This has been included in the v.1.3.11 release. Thank you for your contribution.