starred/mailpit

Fork 0

mirror of https://github.com/axllent/mailpit.git synced 2026-04-26 00:35:51 +03:00

[GH-ISSUE #526] Something changed since version 24 in data structures #337

New issue

Closed

opened 2026-03-15 13:58:35 +03:00 by kerem · 9 comments

kerem commented

2026-03-15 13:58:35 +03:00

Owner

Originally created by @baiomys on GitHub (Jun 23, 2025).
Original GitHub issue: https://github.com/axllent/mailpit/issues/526

Processing email data obtained from WebSockets no longer work in v26

Here is queue:

    data = json.loads(response)
    if data['Type'] == 'new' and max_q_messages > 0 :
         await email_queue.put([lbl, data['Data']])

This is processing:

     msg_rec = email_queue.get_nowait()  
     lbl,data = msg_rec
     await hook_run(pit=_GD['PIT_BY_NAM'][lbl], hook=data)

And this is faulty code since I upgraded to v26

async def hook_run(hook: dict, pit: PitInfo):
    rcpt = hook['To'] + hook['Cc'] + hook['Bcc']

TypeError: can only concatenate list (not "NoneType") to list

Looks like something changed in To, Cc or Bcc

Originally created by @baiomys on GitHub (Jun 23, 2025). Original GitHub issue: https://github.com/axllent/mailpit/issues/526 Processing email data obtained from WebSockets no longer work in v26 Here is queue: ``` data = json.loads(response) if data['Type'] == 'new' and max_q_messages > 0 : await email_queue.put([lbl, data['Data']]) ``` This is processing: ``` msg_rec = email_queue.get_nowait() lbl,data = msg_rec await hook_run(pit=_GD['PIT_BY_NAM'][lbl], hook=data) ``` And this is faulty code since I upgraded to v26 ``` async def hook_run(hook: dict, pit: PitInfo): rcpt = hook['To'] + hook['Cc'] + hook['Bcc'] ``` **_TypeError: can only concatenate list (not "NoneType") to list_** Looks like something changed in To, Cc or Bcc

kerem

2026-03-15 13:58:35 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-15 13:58:52 +03:00

Author

Owner

@axllent commented on GitHub (Jun 23, 2025):

Just so I'm clear, you had version 1.24.0 and now you have v1.26.2? I'm not aware of any changes that would have altered the websocket data structure, so narrowing down the exact version you were on and the version you updated to is necessary so I can compare the code. Please confirm.

@axllent commented on GitHub (Jun 23, 2025): Just so I'm clear, you had version 1.24.0 and now you have v1.26.2? I'm not aware of any changes that would have altered the websocket data structure, so narrowing down the exact version you were on and the version you updated to is necessary so I can compare the code. Please confirm.

kerem commented

2026-03-15 13:58:57 +03:00

Author

Owner

@baiomys commented on GitHub (Jun 24, 2025):

working:

image: axllent/mailpit:v1.24.2

not working (updated on sunday):

image: axllent/mailpit:latest

I guess it is v1.26.2 now, used sendtestemail.com to send test messages

@baiomys commented on GitHub (Jun 24, 2025): working: `image: axllent/mailpit:v1.24.2` not working (updated on sunday): `image: axllent/mailpit:latest` I guess it is v1.26.2 now, used sendtestemail.com to send test messages

kerem commented

2026-03-15 13:59:02 +03:00

Author

Owner

@axllent commented on GitHub (Jun 24, 2025):

From what I can tell, there are no changes at all to any of that message summary data sent via the webhook - with the exception of a new object value called "Username". Everything else should be the exact same as it was before.

What would be helpful is if you could please capture and compare the websocket output (you are processing) from v1.24.2 and latest for the same message - and spot the difference (if there is any). Obviously some fields like the ID would differ, but the address details should be identical.

@axllent commented on GitHub (Jun 24, 2025): From what I can tell, there are no changes at all to any of that message summary data sent via the webhook - with the exception of a new object value called "Username". Everything else should be the exact same as it was before. What would be helpful is if you could please capture and compare the websocket output (you are processing) from `v1.24.2` and `latest` for the same message - and spot the difference (if there is any). Obviously some fields like the ID would differ, but the address details should be identical.

kerem commented

2026-03-15 13:59:07 +03:00

Author

Owner

@baiomys commented on GitHub (Jun 24, 2025):

Was:

"To": [
      {
        "Name": "",
        "Address": "anytext@2tag.org"
      }
    ],
    "Cc": [],
    "Bcc": [
      {
        "Name": "",
        "Address": "~@bucket.2tag.org"
      }
    ],

Now:

"To": [
    {
      "Name": "",
      "Address": "anytext@2tag.org"
    }
  ],
  "Cc": null,
  "Bcc": [
    {
      "Name": "",
      "Address": "~@bucket.2tag.org"
    }
  ],

@baiomys commented on GitHub (Jun 24, 2025): Was: ``` "To": [ { "Name": "", "Address": "anytext@2tag.org" } ], "Cc": [], "Bcc": [ { "Name": "", "Address": "~@bucket.2tag.org" } ], ``` Now: ``` "To": [ { "Name": "", "Address": "anytext@2tag.org" } ], "Cc": null, "Bcc": [ { "Name": "", "Address": "~@bucket.2tag.org" } ], ```

kerem commented

2026-03-15 13:59:12 +03:00

Author

Owner

@axllent commented on GitHub (Jun 24, 2025):

Thank you, that helps me a lot and explains it! I will look into this within the next day or two.

@axllent commented on GitHub (Jun 24, 2025): Thank you, that helps me a lot and explains it! I will look into this within the next day or two.

kerem commented

2026-03-15 13:59:17 +03:00

Author

Owner

@baiomys commented on GitHub (Jun 24, 2025):

Thanks!
I already altered the code just in case. =)
rcpt = (hook.get('To') or []) + (hook.get('Cc') or []) + (hook.get('Bcc') or [])

@baiomys commented on GitHub (Jun 24, 2025): Thanks! I already altered the code just in case. =) `rcpt = (hook.get('To') or []) + (hook.get('Cc') or []) + (hook.get('Bcc') or [])`

kerem commented

2026-03-15 13:59:22 +03:00

Author

Owner

@axllent commented on GitHub (Jun 24, 2025):

Yes, but this doesn't align with the API docs which say the values return an object, which null is not :) Some languages don't care, others do. It's good to have that check in your code anyway, but I still need to fix this either way...

@axllent commented on GitHub (Jun 24, 2025): Yes, but this doesn't align with the API docs which say the values return an object, which `null` is not :) Some languages don't care, others do. It's good to have that check in your code anyway, but I still need to fix this either way...

kerem commented

2026-03-15 13:59:27 +03:00

Author

Owner

@axllent commented on GitHub (Jun 24, 2025):

The fix was pretty easy - and it only impacted the websocket data. I've pushed a fix for this in the edge build and it will be included in a new release this weekend 👍

@axllent commented on GitHub (Jun 24, 2025): The fix was pretty easy - and it only impacted the websocket data. I've pushed a fix for this in the edge build and it will be included in a new release this weekend 👍

kerem commented

2026-03-15 13:59:32 +03:00

Author

Owner

@ghost commented on GitHub (Jun 24, 2025):

func (m *MessageSummary) UnmarshalJSON(data []byte) error {
	type Alias MessageSummary
	aux := &struct {
		*Alias
	}{
		Alias: (*Alias)(m),
	}
	if err := json.Unmarshal(data, &aux); err != nil {
		return err
	}

	// Normalize nil slices to empty
        if m.From == nil {
		m.From = &mail.Address{}
	}
	if m.To == nil {
		m.To = []*mail.Address{}
	}
	if m.Cc == nil {
		m.Cc = []*mail.Address{}
	}
	if m.Bcc == nil {
		m.Bcc = []*mail.Address{}
	}
	if m.ReplyTo == nil {
		m.ReplyTo = []*mail.Address{}
	}
	if m.Tags == nil {
		m.Tags = []string{}
	}

	return nil
}

@ghost commented on GitHub (Jun 24, 2025): ``` func (m *MessageSummary) UnmarshalJSON(data []byte) error { type Alias MessageSummary aux := &struct { *Alias }{ Alias: (*Alias)(m), } if err := json.Unmarshal(data, &aux); err != nil { return err } // Normalize nil slices to empty if m.From == nil { m.From = &mail.Address{} } if m.To == nil { m.To = []*mail.Address{} } if m.Cc == nil { m.Cc = []*mail.Address{} } if m.Bcc == nil { m.Bcc = []*mail.Address{} } if m.ReplyTo == nil { m.ReplyTo = []*mail.Address{} } if m.Tags == nil { m.Tags = []string{} } return nil } ```