mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 08:45:54 +03:00
[GH-ISSUE #441] mailpit.svg file not found when webroot is set #283
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#283
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Lyrkan on GitHub (Feb 12, 2025).
Original GitHub issue: https://github.com/axllent/mailpit/issues/441
Hi there,
Since version 1.22.2 it seems that the mailpit.svg file cannot be loaded when using a webroot.
Using v1.22.2 without a webroot:
Using v1.22.2 with a webroot:
Using v1.22.1 with a webroot:
@NADEE-MJ commented on GitHub (Feb 12, 2025):
I was seeing this as well when using the binary. Installed via the installer on Ubuntu and also generated the binary from the go code using the guide and same result.
@axllent commented on GitHub (Feb 12, 2025):
Sounds like a bug. Thanks for reporting, I'll look into this soon.
@axllent commented on GitHub (Feb 13, 2025):
I found the issue, which was caused in this case by the fact that both your webroot and the filename start with "mailpit"... It was "trimming"
/mailpitoff the virtual path to the file, however it did it multiple times, so/mailpit/mailpit.svgbecame just.svg🤦I have pushed a fix for this, however it hasn't yet been released as I try not release new versions too often (package maintainers get grumpy when I create extra work for them). Is this bug affecting just you, or is it impacting a wider audience (part of a larger Mailpit implementation)?
@NADEE-MJ commented on GitHub (Feb 13, 2025):
Just a heads up I was seeing the same issue with web root set to mail. Not sure if the fix will work for that case as well. The app is still fully usable just an annoying 404.
@axllent commented on GitHub (Feb 13, 2025):
Yes,
/mail/mailpit.svgwould have resulted inpit.svg. I can confirm that this is solved in the bugfix I pushed. My question (to you both) is how big is the impact of this bug for you? If it affects a larger audience then I can release a new version now, otherwise I will wait a couple more days (weekend).@Lyrkan commented on GitHub (Feb 13, 2025):
It can wait, don't worry :)
@axllent commented on GitHub (Feb 15, 2025):
This fix has now been released in v1.22.3. Thanks for reporting the issue!