[GH-ISSUE #357] Link Check: localhost links not detected #237

New issue

Closed

opened 2026-03-15 13:22:02 +03:00 by kerem · 5 comments

kerem commented

2026-03-15 13:22:02 +03:00

Owner

Originally created by @dregad on GitHub (Sep 4, 2024).
Original GitHub issue: https://github.com/axllent/mailpit/issues/357

Hello @axllent,

I was testing the LinkCheck feature, and noticed that localhost links (which I frequently use while developing) are not detected (http://127.0.0.1 works).

php > mail('test@localhost','Test plain link','http://localhost');

I guess this could be fixed with a small adjustment to the Regex. e.g. appending |localhost at the end of the 2nd capturing group.
github.com/axllent/mailpit@dc1a16ed5c/internal/linkcheck/main.go (L13)

PS: many thanks for MailPit, it's awesome ❤️

Originally created by @dregad on GitHub (Sep 4, 2024). Original GitHub issue: https://github.com/axllent/mailpit/issues/357 Hello @axllent, I was testing the LinkCheck feature, and noticed that *localhost* links (which I frequently use while developing) are not detected (http://127.0.0.1 works). ``` php > mail('test@localhost','Test plain link','http://localhost'); ``` ![image](https://github.com/user-attachments/assets/3733dbac-69dc-41e6-99f4-e6e717182ccd) ![image](https://github.com/user-attachments/assets/52165505-c419-449b-b5db-a8347d283c01) I guess this could be fixed with a small adjustment to the Regex. e.g. appending `|localhost` at the end of the 2nd capturing group. https://github.com/axllent/mailpit/blob/dc1a16ed5c065486b5edd24623489b935c7ed4d3/internal/linkcheck/main.go#L13 PS: many thanks for MailPit, it's awesome ❤️

kerem closed this issue

2026-03-15 13:22:07 +03:00

kerem commented

2026-03-15 13:22:13 +03:00

Author

Owner

@dregad commented on GitHub (Sep 4, 2024):

Sorry, forgot to mention this is with v1.18.3. I realize it's somewhat out of date, but I can't upgrade just now, and as far as I can tell the regex is the same in 1.20.3 so I don't think it will make any difference but I'll test again later with the latest version.

@dregad commented on GitHub (Sep 4, 2024): Sorry, forgot to mention this is with v1.18.3. I realize it's somewhat out of date, but I can't upgrade just now, and as far as I can tell the regex is the same in 1.20.3 so I don't think it will make any difference but I'll test again later with the latest version.

kerem commented

2026-03-15 13:22:18 +03:00

Author

Owner

@dregad commented on GitHub (Sep 4, 2024):

Same behavior confirmed with v1.20.3.

@dregad commented on GitHub (Sep 4, 2024): Same behavior confirmed with v1.20.3.

kerem commented

2026-03-15 13:22:23 +03:00

Author

Owner

@axllent commented on GitHub (Sep 5, 2024):

Hi @dregad - I can confirm your issue - the frontend JavaScript was far more relaxed in how it detected a "valid" URL vs: the "backend" for link checking. I have just pushed a fix and released it as part of v1.20.4. Please confirm this new release fixes the issue for you?

@axllent commented on GitHub (Sep 5, 2024): Hi @dregad - I can confirm your issue - the frontend JavaScript was far more relaxed in how it detected a "valid" URL vs: the "backend" for link checking. I have just pushed a fix and released it as part of [v1.20.4](https://github.com/axllent/mailpit/releases/tag/v1.20.4). Please confirm this new release fixes the issue for you?

kerem commented

2026-03-15 13:22:28 +03:00

Author

Owner

@dregad commented on GitHub (Sep 5, 2024):

Thanks for responding so quickly. I think your fix should do the trick, will test and confirm later today!

@dregad commented on GitHub (Sep 5, 2024): Thanks for responding so quickly. I think your fix should do the trick, will test and confirm later today!

kerem commented

2026-03-15 13:22:34 +03:00

Author

Owner

@dregad commented on GitHub (Sep 5, 2024):

Confirmed working OK in 1.20.4, thank you very much ! 🚀

@dregad commented on GitHub (Sep 5, 2024): Confirmed working OK in 1.20.4, thank you very much ! 🚀