[GH-ISSUE #26] MP_TAG does not work #22

New issue

Closed

opened 2026-03-15 12:09:12 +03:00 by kerem · 4 comments

kerem commented

2026-03-15 12:09:12 +03:00

Owner

Originally created by @LukaszRacon on GitHub (Dec 8, 2022).
Original GitHub issue: https://github.com/axllent/mailpit/issues/26

Tags don't work when defined with MP_TAG environment variable. Works fine with -t command.

Test:
docker run --rm -it -p 1025:1025 -p 8025:8025 -e MP_TAG="abc=\"ABC\"" axllent/mailpit:v1.3.2 -v

Looks like default value is missing:
https://github.com/axllent/mailpit/blob/master/cmd/root.go#L145:

- rootCmd.Flags().StringVarP(&config.SMTPCLITags, "tag", "t", "", "Tag new messages matching filters")
+ rootCmd.Flags().StringVarP(&config.SMTPCLITags, "tag", "t", "config.SMTPCLITags", "Tag new messages matching filters")

Originally created by @LukaszRacon on GitHub (Dec 8, 2022). Original GitHub issue: https://github.com/axllent/mailpit/issues/26 Tags don't work when defined with `MP_TAG` environment variable. Works fine with `-t` command. Test: `docker run --rm -it -p 1025:1025 -p 8025:8025 -e MP_TAG="abc=\"ABC\"" axllent/mailpit:v1.3.2 -v` Looks like default value is missing: https://github.com/axllent/mailpit/blob/master/cmd/root.go#L145: ``` - rootCmd.Flags().StringVarP(&config.SMTPCLITags, "tag", "t", "", "Tag new messages matching filters") + rootCmd.Flags().StringVarP(&config.SMTPCLITags, "tag", "t", "config.SMTPCLITags", "Tag new messages matching filters") ```

kerem closed this issue

2026-03-15 12:09:18 +03:00

kerem commented

2026-03-15 12:09:23 +03:00

Author

Owner

@axllent commented on GitHub (Dec 8, 2022):

@LukaszRacon Thanks for the bug report, and you're totally right - this was missing. I have fixed this in the latest release (v1.3.3) which should finish building within the next few minutes (binaries & docker). Please let me know if this fixes it for you?

@axllent commented on GitHub (Dec 8, 2022): @LukaszRacon Thanks for the bug report, and you're totally right - this was missing. I have fixed this in the latest release (v1.3.3) which should finish building within the next few minutes (binaries & docker). Please let me know if this fixes it for you?

kerem commented

2026-03-15 12:09:29 +03:00

Author

Owner

@LukaszRacon commented on GitHub (Dec 8, 2022):

Thank you for quick response and developing mailpit - looks and works great.
The issue is still there - in commit you have used wrong key: SMTPSSLKey instead of SMTPCLITags.

@LukaszRacon commented on GitHub (Dec 8, 2022): Thank you for quick response and developing mailpit - looks and works great. The issue is still there - in commit you have used wrong key: `SMTPSSLKey` instead of `SMTPCLITags`.

kerem commented

2026-03-15 12:09:34 +03:00

Author

Owner

@axllent commented on GitHub (Dec 8, 2022):

😵‍💫 Good catch (again!). That will teach me to try multitask! v1.3.4 with the real fix is being released now. Sorry about that... and thanks for the positive comments!

@axllent commented on GitHub (Dec 8, 2022): :face_with_spiral_eyes: Good catch (again!). That will teach me to try multitask! v1.3.4 with the real fix is being released now. Sorry about that... and thanks for the positive comments!

kerem commented

2026-03-15 12:09:39 +03:00

Author

Owner

@LukaszRacon commented on GitHub (Dec 8, 2022):

Confirming that all worked. Thanks again!

@LukaszRacon commented on GitHub (Dec 8, 2022): Confirming that all worked. Thanks again!