mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 16:56:00 +03:00
[GH-ISSUE #210] Favicon notification badge does not render correctly #140
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#140
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @federicobond on GitHub (Nov 23, 2023).
Original GitHub issue: https://github.com/axllent/mailpit/issues/210
I have some code laying around that implements this well, if you are interested I can submit a pull request for you to evaluate.
@axllent commented on GitHub (Nov 23, 2023):
Yes thank you, I'd be very interested to see what you have @federicobond. The library I'm currently using is fairly old, but was the best one I could find at the time that didn't suffer from bad performance, and which (I thought anyway) rendered ok on all major browsers. Out of curiosity, what browser and platform are you using?
@federicobond commented on GitHub (Nov 23, 2023):
That's Firefox on MacOS Sonoma 14.1. I'll look for some time these days to put something together.
@federicobond commented on GitHub (Nov 23, 2023):
Thanks for the quick answer!
@axllent commented on GitHub (Nov 24, 2023):
Thank you too. I realise that implementing a PR may be the most difficult thing for you, so even if you could point me in the direction of a better library that would be great (ie: I can implement it myself).
@federicobond commented on GitHub (Nov 24, 2023):
Sure, I put together a quick demo here: https://github.com/federicobond/badgicon
Feel free to copy and paste the code there and adapt it to your needs, I release every right to you.
@axllent commented on GitHub (Nov 25, 2023):
Thank you for this, I will definitely have a good look when I get some time (next weekend as I am away for the next 5 days).
In the meantime, could you please explain to me what the advantage is of your library vs: Tinycon (the one Mailpit uses)? I also had a quick play in my browser and has to bump the font size from 28 to 38 to get it similar to Mailpit's one as 28 was just too small to read, so I am wondering if it is just a font selection issue (ie: you don't have Arial installed).
@axllent commented on GitHub (Dec 1, 2023):
I have made a small change to the existing implementation to add a fallback font (sans-serif) to see if this helps your problem (I suspect you simply don't have Arial installed). This change has been released in v1.10.2.
Whilst I am still open to implementing your solution, I would like to know what the advantage is of your implementation vs: the tinyicon library I'm using before I do so, and in order to use yours (or a variation of yours) I would also require your project to have a valid LICENSE file in the repo (eg: something like this). Unfortunately just a comment in an issue stating one can use code does not legally make it open source ;-)
@parth391 commented on GitHub (Dec 2, 2023):
Still having the same problem
Mailpit Version: 1.10.2
Firefox Version: 120.0.1 (64-bit)
MacOS Version: 14.1.2 (23B92)
@axllent commented on GitHub (Dec 2, 2023):
@parth391 Thanks for the feedback. Can you please open this and confirm whether the favicon appears as it should on the same platform/browser you tested previously? Thanks.
@parth391 commented on GitHub (Dec 2, 2023):
@axllent, Link work perfectly on Firefox and Chrome on MacOS.
Chrome:
Firefox:
@federicobond commented on GitHub (Dec 2, 2023):
Hi, I can confirm the test link looks good in my computer too.
@axllent commented on GitHub (Dec 2, 2023):
Thanks to you both for the confirmation. I'll continue to work on this in the coming days as there are a few performance issues I need to address (not the fault of the code, but rather the CPU usage caused by the image generation when the favicon is updated often like in the demo). I also need to add a reset function for when there are no unread counts.
@axllent commented on GitHub (Dec 7, 2023):
@federicobond & @parth391 - I have just released v1.10.3 which is using a modified version of @federicobond's script (thank you again!). Please have a test and let me know if this solves the issue on MacOS?
@parth391 commented on GitHub (Dec 7, 2023):
@axllent, v1.10.4 fix the issue on MacOS.
Thanks.