mirror of
https://github.com/axllent/mailpit.git
synced 2026-04-26 08:45:54 +03:00
[GH-ISSUE #204] Feature request: Link Check - allow insecure/selfsigned https:// links to be checked #134
Labels
No labels
awaiting feedback
bug
docker
documentation
enhancement
github_actions
invalid
pull-request
question
stale
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mailpit#134
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wadabum on GitHub (Nov 1, 2023).
Original GitHub issue: https://github.com/axllent/mailpit/issues/204
My QA-Env. has "real" domains bent back to itself in /etc/hosts, using a self-signed certificate.
Cannot connect to serverStatusCode: 0, Status: "certificate signed by unknown authority"in the json-responseAs minimal fix, some general "link-check-ignore-https-errors" flag would be nice. (as example Puppeteer´s "ignoreHTTPSErrors")
The ultimate fix would also allow to directly specify the to-be-allowed-certificate/CA
(imagine
--link-check-no-verify [false]|true|/etc/ssl/certs/ssl-cert-snakeoil.pem) (as example see Guzzle´s verify options)@wadabum commented on GitHub (Nov 1, 2023):
in addition to that I´ve noticed:
/proxy?url=...URLs)Get "https://...": tls: failed to verify certificate: x509: certificate signed by unknown authorityso when adding a flag for allowing link-checker this should be implemented here too,
-> with either the same --arg-switches or one for each I dont know ;-)
@axllent commented on GitHub (Nov 2, 2023):
@wadabum I am really trying to minimize the number of CLI arguments (and environment variables), so I am in favour of a single generic flag, something like
--ignore-tls-errorswhich one can optionally apply, and be used for multiple things (including SMTP). I need to give this some thought first as it should be clear what it does (and not confuse users).@axllent commented on GitHub (Nov 11, 2023):
@wadabum I have added an option for this in v1.10.0 (env
MP_ALLOW_UNTRUSTED_TLSor--allow-untrusted-tls). Please confirm this solves your issue?@wadabum commented on GitHub (Nov 11, 2023):
Working perfectly (for html&linkcheck)
Thank you very much 👌