[PR #30] [MERGED] Menu: conver to client side JS. And fix a syntax error. #62

New issue

Closed

opened 2026-03-04 12:24:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 12:24:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brvphoenix/luci-app-wrtbwmon/pull/30
Author: @kongfl888
Created: 8/20/2020
Status: ✅ Merged
Merged: 2/17/2021
Merged by: @brvphoenix

Base: master ← Head: 19.07-patch

📝 Commits (1)

d718976 Menu:conver to client side JS.

📊 Changes

2 files changed (+41 additions, -20 deletions)

View changed files

➖ luci-app-wrtbwmon/luasrc/controller/wrtbwmon.lua (+0 -20)
➕ luci-app-wrtbwmon/root/usr/share/luci/menu.d/luci-app-wrtbwmon.json (+41 -0)

📄 Description

Since the new version of Luci is used, it is not appropriate to use controller/*.lua again.

Let it all use js.

And fix a syntax error which will case cause errors in Edge browsers and some mobile browsers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brvphoenix/luci-app-wrtbwmon/pull/30 **Author:** [@kongfl888](https://github.com/kongfl888) **Created:** 8/20/2020 **Status:** ✅ Merged **Merged:** 2/17/2021 **Merged by:** [@brvphoenix](https://github.com/brvphoenix) **Base:** `master` ← **Head:** `19.07-patch` --- ### 📝 Commits (1) - [`d718976`](https://github.com/brvphoenix/luci-app-wrtbwmon/commit/d718976943d61c828a18b2b439e98d60eb00587a) Menu:conver to client side JS. ### 📊 Changes **2 files changed** (+41 additions, -20 deletions) <details> <summary>View changed files</summary> ➖ `luci-app-wrtbwmon/luasrc/controller/wrtbwmon.lua` (+0 -20) ➕ `luci-app-wrtbwmon/root/usr/share/luci/menu.d/luci-app-wrtbwmon.json` (+41 -0) </details> ### 📄 Description Since the new version of Luci is used, it is not appropriate to use controller/*.lua again. Let it all use js. And fix a syntax error which will case cause errors in Edge browsers and some mobile browsers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>