starred/luci-app-wrtbwmon-brvphoenix
1
0
Fork 0
mirror of https://github.com/brvphoenix/luci-app-wrtbwmon.git synced 2026-04-27 09:15:52 +03:00
Code Issues 14 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #21] Case insensitive MAC addresses in the Custom User File #18

New issue
Closed
opened 2026-03-04 12:23:59 +03:00 by kerem · 11 comments
kerem commented 2026-03-04 12:23:59 +03:00
Owner
Copy link

Originally created by @sinancetinkaya on GitHub (Jun 14, 2020).
Original GitHub issue: https://github.com/brvphoenix/luci-app-wrtbwmon/issues/21

Current version doesn't recognize upper case MAC addresses

Originally created by @sinancetinkaya on GitHub (Jun 14, 2020). Original GitHub issue: https://github.com/brvphoenix/luci-app-wrtbwmon/issues/21 Current version doesn't recognize upper case MAC addresses
kerem 2026-03-04 12:23:59 +03:00
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@brvphoenix commented on GitHub (Jun 15, 2020):

@sinancetinkaya
Have been fixed in 441b0a845b.

Test on this artifact.

<!-- gh-comment-id:643854747 --> @brvphoenix commented on GitHub (Jun 15, 2020): @sinancetinkaya Have been fixed in 441b0a845b0340e7be1192dc6a8e2314ea6c070d. Test on this [artifact](https://github.com/brvphoenix/luci-app-wrtbwmon/suites/795380001/artifacts/8522934).
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@sinancetinkaya commented on GitHub (Jun 15, 2020):

Tested the ipk file on the artifact link, it's not working. Uppercase MAC addresses don't show up in the list.

Besides, Kiougar's luci-wrtbwmon was pulling the host names from /etc/config/dhcp as well.

config host
	option dns '1'
	option mac 'XX:XX:XX:XX:XX:XX'
	option ip '192.168.1.2'
	option name 'Sinan-PC'

Wouldn't be this a better approach?

<!-- gh-comment-id:644193258 --> @sinancetinkaya commented on GitHub (Jun 15, 2020): Tested the ipk file on the artifact link, it's not working. Uppercase MAC addresses don't show up in the list. Besides, Kiougar's luci-wrtbwmon was pulling the host names from `/etc/config/dhcp` as well. ``` config host option dns '1' option mac 'XX:XX:XX:XX:XX:XX' option ip '192.168.1.2' option name 'Sinan-PC' ``` Wouldn't be this a better approach?
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@brvphoenix commented on GitHub (Jun 16, 2020):

Current pre-released ipk is case insensitive in the custom user file. I have tested lower case, upper case and mixed case and erverthing is OK. You'd better provide more info for debuging.

The dhcp is pulled from luci-rpc and it depends on the upstream OpenWrt whether it can be resolved from /etc/config/dhcp.

<!-- gh-comment-id:644490878 --> @brvphoenix commented on GitHub (Jun 16, 2020): Current pre-released ipk is case insensitive in the custom user file. I have tested lower case, upper case and mixed case and erverthing is OK. You'd better provide more info for debuging. The dhcp is pulled from luci-rpc and it depends on the upstream OpenWrt whether it can be resolved from `/etc/config/dhcp`.
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@sinancetinkaya commented on GitHub (Jun 16, 2020):

The link of ipk you gave me is correct, right?
Because I tried uppercase Mac address and it didn't show up in the traffic
tab.

On Tue, 16 Jun 2020, 05:22 Van Waholtz, notifications@github.com wrote:

Current pre-released ipk is case insensitive in the custom user file. I
have tested lower case, upper case and mixed case and erverthing is OK.

The dhcp is pulled from luci-rpc and it depends on the upstream OpenWrt
whether it can be resolved from /etc/config/dhcp.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/brvphoenix/luci-app-wrtbwmon/issues/21#issuecomment-644490878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUNHR6BXTNLDATU4GAPP23RW3JNLANCNFSM4N5TXPRQ
.

<!-- gh-comment-id:644492594 --> @sinancetinkaya commented on GitHub (Jun 16, 2020): The link of ipk you gave me is correct, right? Because I tried uppercase Mac address and it didn't show up in the traffic tab. On Tue, 16 Jun 2020, 05:22 Van Waholtz, <notifications@github.com> wrote: > Current pre-released ipk is case insensitive in the custom user file. I > have tested lower case, upper case and mixed case and erverthing is OK. > > The dhcp is pulled from luci-rpc and it depends on the upstream OpenWrt > whether it can be resolved from /etc/config/dhcp. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/brvphoenix/luci-app-wrtbwmon/issues/21#issuecomment-644490878>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAUNHR6BXTNLDATU4GAPP23RW3JNLANCNFSM4N5TXPRQ> > . >
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@brvphoenix commented on GitHub (Jun 16, 2020):

https://github.com/brvphoenix/luci-app-wrtbwmon/releases/download/release-2.0.3/luci-app-wrtbwmon_2.0.3-1_all.ipk

<!-- gh-comment-id:644493530 --> @brvphoenix commented on GitHub (Jun 16, 2020): https://github.com/brvphoenix/luci-app-wrtbwmon/releases/download/release-2.0.3/luci-app-wrtbwmon_2.0.3-1_all.ipk
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@sinancetinkaya commented on GitHub (Jun 16, 2020):

image
image
image

<!-- gh-comment-id:644499428 --> @sinancetinkaya commented on GitHub (Jun 16, 2020): ![image](https://user-images.githubusercontent.com/2675655/84726196-06f61580-af95-11ea-8788-9c2e7982b22f.png) ![image](https://user-images.githubusercontent.com/2675655/84726218-0fe6e700-af95-11ea-88e1-ddfd96b3ca3e.png) ![image](https://user-images.githubusercontent.com/2675655/84726299-3ad13b00-af95-11ea-8b55-258bcde4482d.png)
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@sinancetinkaya commented on GitHub (Jun 16, 2020):

OpenWrt SNAPSHOT r13573-03a0b7b7e5 / LuCI Master git-20.154.54590-05f07e5

<!-- gh-comment-id:644500435 --> @sinancetinkaya commented on GitHub (Jun 16, 2020): OpenWrt SNAPSHOT r13573-03a0b7b7e5 / LuCI Master git-20.154.54590-05f07e5
kerem commented 2026-03-04 12:24:00 +03:00
Author
Owner
Copy link

@brvphoenix commented on GitHub (Jun 16, 2020):

Test to cler the cache. If you are using chrome, press F12, check Disable cache and refresh the page.
screenshot

<!-- gh-comment-id:644501643 --> @brvphoenix commented on GitHub (Jun 16, 2020): Test to cler the cache. If you are using chrome, press F12, check `Disable cache ` and refresh the page. ![screenshot](https://user-images.githubusercontent.com/30111323/84726570-c495fe00-afbf-11ea-95f3-68ec440f13cf.PNG)
kerem commented 2026-03-04 12:24:01 +03:00
Author
Owner
Copy link

@sinancetinkaya commented on GitHub (Jun 16, 2020):

Wait a minute, did some change in config options and saved. After that, the host name appeared.
luci-app-wrtbwmon requires a restart after custom user file is changed?

<!-- gh-comment-id:644728772 --> @sinancetinkaya commented on GitHub (Jun 16, 2020): Wait a minute, did some change in config options and saved. After that, the host name appeared. luci-app-wrtbwmon requires a restart after custom user file is changed?
kerem commented 2026-03-04 12:24:01 +03:00
Author
Owner
Copy link

@brvphoenix commented on GitHub (Jun 16, 2020):

@brvphoenix I'm using Firefox, disabled cache.
image

The progressbar's labels upflow and downflow have been changed to Upstream and Downstream in the new release. The screenshots have shown that you are not using the latest version. Thus, I'm very sure that there are something wrong in you side.

It is mostly likely that the your browser has not replaced these old cached *.js files.

<!-- gh-comment-id:644732981 --> @brvphoenix commented on GitHub (Jun 16, 2020): > @brvphoenix I'm using Firefox, disabled cache. > ![image](https://user-images.githubusercontent.com/2675655/84772991-6deeeb00-afe4-11ea-9127-880c9be44c84.png) The progressbar's labels `upflow` and `downflow` have been changed to `Upstream` and `Downstream` in the new release. The screenshots have shown that you are not using the latest version. Thus, I'm very sure that there are something wrong in you side. It is mostly likely that the your browser has not replaced these old cached *.js files.
kerem commented 2026-03-04 12:24:01 +03:00
Author
Owner
Copy link

@sinancetinkaya commented on GitHub (Jun 16, 2020):

yeah they are changed now too
image

<!-- gh-comment-id:644734246 --> @sinancetinkaya commented on GitHub (Jun 16, 2020): yeah they are changed now too ![image](https://user-images.githubusercontent.com/2675655/84774716-ebb3f600-afe6-11ea-92df-c069e3ad47fd.png)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/github_actions/actions/upload-artifact-6
dependabot/github_actions/actions/checkout-6
dependabot/github_actions/actions/github-script-8
dependabot/github_actions/actions/stale-10
tmp
lua
old-master
dev
release-2.0.13
release-2.0.12
release-2.0.11
release-2.0.10
release-2.0.9
release-2.0.8
release-2.0.7
release-2.0.6
release-2.0.5
release-2.0.4
release-2.0.3
release-2.0.2
release-2.0.1
release-2.0.0
release-1.6.3
Labels
Clear labels   
Can't reproduce

   
WaitingInfo

   
bug

   
compatibility

   
duplicate

   
invalid

   
no-issue-activity

   
not a bug

   
pull-request

Mirrored from GitHub Pull Request

  
question
No labels
Can't reproduce
WaitingInfo
bug
compatibility
duplicate
invalid
no-issue-activity
not a bug
pull-request
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/luci-app-wrtbwmon-brvphoenix#18
No description provided.