[PR #18] [CLOSED] Sort SMS by part number #35

New issue

Closed

opened 2026-03-04 12:10:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 12:10:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/4IceG/luci-app-sms-tool/pull/18
Author: @chbgdn
Created: 9/25/2022
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

551d59d Sort SMS by part number

📊 Changes

1 file changed (+15 additions, -3 deletions)

View changed files

📝 luci-app-sms-tool/luasrc/view/modem/readsms.htm (+15 -3)

📄 Description

Sometimes sms_tool with Fibocom L860 return SMS inconsistently, something like

id 1 = part 5
id 2 = part 1
id 3 = part 2
id 4 = part 3
id 5 = part 4

With 'merge split messages' enabled I got mess like 'part5-part1-part2-part3-part4'.
My JS knowlage is poor, so its a dirty fix for this, but it works. If you can fix it more clear - please close this PR. Thanks.
P.S. Fix didn't tested with other modems, so it may broke something.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/4IceG/luci-app-sms-tool/pull/18 **Author:** [@chbgdn](https://github.com/chbgdn) **Created:** 9/25/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`551d59d`](https://github.com/4IceG/luci-app-sms-tool/commit/551d59d391fd5ae97cd1d9efb32c8beb44852c5a) Sort SMS by part number ### 📊 Changes **1 file changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `luci-app-sms-tool/luasrc/view/modem/readsms.htm` (+15 -3) </details> ### 📄 Description Sometimes sms_tool with Fibocom L860 return SMS inconsistently, something like ``` id 1 = part 5 id 2 = part 1 id 3 = part 2 id 4 = part 3 id 5 = part 4 ``` With 'merge split messages' enabled I got mess like 'part5-part1-part2-part3-part4'. My JS knowlage is poor, so its a dirty fix for this, but it works. If you can fix it more clear - please close this PR. Thanks. P.S. Fix didn't tested with other modems, so it may broke something. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>